From: Lee Jones <lee.jones@linaro.org>
To: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>
Subject: Re: [PATCH 1/3] mfd: ds1374: Introduce Dallas/Maxim DS1374 MFD core driver
Date: Mon, 22 Jun 2020 12:14:13 +0100 [thread overview]
Message-ID: <20200622111413.GV954398@dell> (raw)
In-Reply-To: <HK2PR01MB328111AB2520315A7D4A1172FA970@HK2PR01MB3281.apcprd01.prod.exchangelabs.com>
On Mon, 22 Jun 2020, Johnson CH Chen (陳昭勳) wrote:
> Dallas/Maxim DS1374 is a counter designed to continuously count
> time in seconds. It provides an I2C interface to the host to
> access RTC clock or Alarm/Watchdog timer.
>
> Add MFD Core driver, supporting the I2C communication to RTC and
> Watchdog devices.
>
> Signed-off-by: Johnson Chen <johnsonch.chen@moxa.com>
> ---
> drivers/mfd/Kconfig | 11 +++++
> drivers/mfd/Makefile | 2 +
> drivers/mfd/ds1374.c | 101 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 114 insertions(+)
> create mode 100644 drivers/mfd/ds1374.c
Not sure I see the point of this driver.
How/where is the device part registered?
Is it DT only? If not, what else?
Also where are the bindings?
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 687e9c848053w.d16031f4b487 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1980,6 +1980,17 @@ config MFD_STM32_LPTIMER
> To compile this driver as a module, choose M here: the
> module will be called stm32-lptimer.
>
> +config MFD_DS1374
> + tristate "Support for Dallas/Maxim DS1374"
> + depends on I2C
> + select MFD_CORE
> + help
> + Say yes here to add support for Dallas/Maxim DS1374 Semiconductor.
> + This driver provides RTC and watchdog.
> +
> + This driver can also be built as a module. If so, module will be
> + called ds1374.
> +
> config MFD_STM32_TIMERS
> tristate "Support for STM32 Timers"
> depends on (ARCH_STM32 && OF) || COMPILE_TEST
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-06-22 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 10:03 [PATCH 1/3] mfd: ds1374: Introduce Dallas/Maxim DS1374 MFD core driver Johnson CH Chen (陳昭勳)
2020-06-22 11:14 ` Lee Jones [this message]
2020-06-22 14:26 ` Guenter Roeck
2020-06-22 15:01 ` Alexandre Belloni
2020-06-23 7:12 ` Johnson CH Chen (陳昭勳)
2020-06-22 15:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622111413.GV954398@dell \
--to=lee.jones@linaro.org \
--cc=JohnsonCH.Chen@moxa.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).