From: kernel test robot <lkp@intel.com>
To: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: kbuild-all@lists.01.org,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/3] mfd: ds1374: Introduce Dallas/Maxim DS1374 MFD core driver
Date: Mon, 22 Jun 2020 23:38:00 +0800 [thread overview]
Message-ID: <202006222355.cumpS11z%lkp@intel.com> (raw)
In-Reply-To: <HK2PR01MB328111AB2520315A7D4A1172FA970@HK2PR01MB3281.apcprd01.prod.exchangelabs.com>
[-- Attachment #1: Type: text/plain, Size: 2471 bytes --]
Hi "Johnson,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on linux/master linus/master v5.8-rc2 next-20200622]
[cannot apply to ljones-mfd/for-mfd-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Johnson-CH-Chen/Use-MFD-for-Dallas-Maxim-DS1374-driver-series/20200622-180544
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/mfd/ds1374.c: In function 'ds1374_suspend':
>> drivers/mfd/ds1374.c:56:3: error: implicit declaration of function 'enable_irq_wake' [-Werror=implicit-function-declaration]
56 | enable_irq_wake(client->irq);
| ^~~~~~~~~~~~~~~
drivers/mfd/ds1374.c: In function 'ds1374_resume':
>> drivers/mfd/ds1374.c:65:3: error: implicit declaration of function 'disable_irq_wake' [-Werror=implicit-function-declaration]
65 | disable_irq_wake(client->irq);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/enable_irq_wake +56 drivers/mfd/ds1374.c
49
50 #ifdef CONFIG_PM_SLEEP
51 static int ds1374_suspend(struct device *dev)
52 {
53 struct i2c_client *client = to_i2c_client(dev);
54
55 if (client->irq > 0 && device_may_wakeup(&client->dev))
> 56 enable_irq_wake(client->irq);
57 return 0;
58 }
59
60 static int ds1374_resume(struct device *dev)
61 {
62 struct i2c_client *client = to_i2c_client(dev);
63
64 if (client->irq > 0 && device_may_wakeup(&client->dev))
> 65 disable_irq_wake(client->irq);
66 return 0;
67 }
68 #endif
69
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63049 bytes --]
prev parent reply other threads:[~2020-06-22 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 10:03 [PATCH 1/3] mfd: ds1374: Introduce Dallas/Maxim DS1374 MFD core driver Johnson CH Chen (陳昭勳)
2020-06-22 11:14 ` Lee Jones
2020-06-22 14:26 ` Guenter Roeck
2020-06-22 15:01 ` Alexandre Belloni
2020-06-23 7:12 ` Johnson CH Chen (陳昭勳)
2020-06-22 15:38 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006222355.cumpS11z%lkp@intel.com \
--to=lkp@intel.com \
--cc=JohnsonCH.Chen@moxa.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).