Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver

From: Guenter Roeck <linux@roeck-us.net>
To: Timothy Myers <timothy.myers@adtran.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Boike <david.boike@adtran.com>
Subject: Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver
Date: Fri, 26 Jun 2020 14:51:33 -0700	[thread overview]
Message-ID: <20200626215133.GB254814@roeck-us.net> (raw)
In-Reply-To: <CH2PR19MB35903F8A6A46864C47A720029D930@CH2PR19MB3590.namprd19.prod.outlook.com>

On Fri, Jun 26, 2020 at 01:39:43PM +0000, Timothy Myers wrote:
> Add the common "nowayout" parameter to booke_wdt to make this behavior
> selectable at runtime and to make the implementation more consistent with
> many other watchdog drivers.
> 
> Signed-off-by: Timothy Myers <timothy.myers@adtran.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/booke_wdt.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 9d09bbfdef20..7817fb976f9c 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -39,6 +39,11 @@ static bool booke_wdt_enabled;
>  module_param(booke_wdt_enabled, bool, 0);
>  static int  booke_wdt_period = CONFIG_BOOKE_WDT_DEFAULT_TIMEOUT;
>  module_param(booke_wdt_period, int, 0);
> +static bool nowayout = WATCHDOG_NOWAYOUT;
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout,
> +               "Watchdog cannot be stopped once started (default="
> +                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> 
>  #ifdef CONFIG_PPC_FSL_BOOK3E
> 
> @@ -215,7 +220,6 @@ static void __exit booke_wdt_exit(void)
>  static int __init booke_wdt_init(void)
>  {
>         int ret = 0;
> -       bool nowayout = WATCHDOG_NOWAYOUT;
> 
>         pr_info("powerpc book-e watchdog driver loaded\n");
>         booke_wdt_info.firmware_version = cur_cpu_spec->pvr_value;
> 
> base-commit: dd0d718152e4c65b173070d48ea9dfc06894c3e5
> --
> 2.20.1
> 
> 
> 
> Timothy Myers
> Software Design Engineer
> 
> Office: 256.963.8844
> Email: timothy.myers@adtran.com<https://owa.adtran.com/owa/redir.aspx?C=LNINRERj1VQgAKE9UNiu-b2J50yb_mKuK9OX8J4spjQqMzmAKlzUCA..&URL=mailto%3atom.patterson%40adtran.com>
> Web: www.adtran.com<https://owa.adtran.com/owa/redir.aspx?C=AO4_0fpgN4Gmyy4bPe0sTxLKfRJry5Qrse3aJSw01zEqMzmAKlzUCA..&URL=http%3a%2f%2fs.bl-1.com%2fh%2fCoY1mz9%3furl%3dhttp%3a%2f%2fwww.adtran.com>
> 
> ADTRAN
> 901 Explorer Boulevard
> Huntsville, AL 35806 - USA