Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver
       [not found] <CH2PR19MB35903F8A6A46864C47A720029D930@CH2PR19MB3590.namprd19.prod.outlook.com>
@ 2020-06-26 21:51 ` Guenter Roeck
       [not found]   ` <CH2PR19MB359071AAD5258D75F7255CA99D690@CH2PR19MB3590.namprd19.prod.outlook.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2020-06-26 21:51 UTC (permalink / raw)
  To: Timothy Myers; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, David Boike

On Fri, Jun 26, 2020 at 01:39:43PM +0000, Timothy Myers wrote:
> Add the common "nowayout" parameter to booke_wdt to make this behavior
> selectable at runtime and to make the implementation more consistent with
> many other watchdog drivers.
> 
> Signed-off-by: Timothy Myers <timothy.myers@adtran.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/booke_wdt.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 9d09bbfdef20..7817fb976f9c 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -39,6 +39,11 @@ static bool booke_wdt_enabled;
>  module_param(booke_wdt_enabled, bool, 0);
>  static int  booke_wdt_period = CONFIG_BOOKE_WDT_DEFAULT_TIMEOUT;
>  module_param(booke_wdt_period, int, 0);
> +static bool nowayout = WATCHDOG_NOWAYOUT;
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout,
> +               "Watchdog cannot be stopped once started (default="
> +                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> 
>  #ifdef CONFIG_PPC_FSL_BOOK3E
> 
> @@ -215,7 +220,6 @@ static void __exit booke_wdt_exit(void)
>  static int __init booke_wdt_init(void)
>  {
>         int ret = 0;
> -       bool nowayout = WATCHDOG_NOWAYOUT;
> 
>         pr_info("powerpc book-e watchdog driver loaded\n");
>         booke_wdt_info.firmware_version = cur_cpu_spec->pvr_value;
> 
> base-commit: dd0d718152e4c65b173070d48ea9dfc06894c3e5
> --
> 2.20.1
> 
> 
> 
> Timothy Myers
> Software Design Engineer
> 
> Office: 256.963.8844
> Email: timothy.myers@adtran.com<https://owa.adtran.com/owa/redir.aspx?C=LNINRERj1VQgAKE9UNiu-b2J50yb_mKuK9OX8J4spjQqMzmAKlzUCA..&URL=mailto%3atom.patterson%40adtran.com>
> Web: www.adtran.com<https://owa.adtran.com/owa/redir.aspx?C=AO4_0fpgN4Gmyy4bPe0sTxLKfRJry5Qrse3aJSw01zEqMzmAKlzUCA..&URL=http%3a%2f%2fs.bl-1.com%2fh%2fCoY1mz9%3furl%3dhttp%3a%2f%2fwww.adtran.com>
> 
> ADTRAN
> 901 Explorer Boulevard
> Huntsville, AL 35806 - USA

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver
       [not found]   ` <CH2PR19MB359071AAD5258D75F7255CA99D690@CH2PR19MB3590.namprd19.prod.outlook.com>
@ 2020-07-06 13:51     ` Guenter Roeck
  0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2020-07-06 13:51 UTC (permalink / raw)
  To: Timothy Myers; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, David Boike

On 7/6/20 4:54 AM, Timothy Myers wrote:
> 
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Guenter Roeck <groeck7@gmail.com> on behalf of Guenter Roeck <linux@roeck-us.net>
> *Sent:* Friday, June 26, 2020 4:51 PM
> *To:* Timothy Myers <timothy.myers@adtran.com>
> *Cc:* Wim Van Sebroeck <wim@linux-watchdog.org>; linux-watchdog@vger.kernel.org <linux-watchdog@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; David Boike <david.boike@adtran.com>
> *Subject:* Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver
>  
> On Fri, Jun 26, 2020 at 01:39:43PM +0000, Timothy Myers wrote:
>> Add the common "nowayout" parameter to booke_wdt to make this behavior
>> selectable at runtime and to make the implementation more consistent with
>> many other watchdog drivers.
>>
>> Signed-off-by: Timothy Myers <timothy.myers@adtran.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Hello,
>     I also have a similar question as Tiezhu recently. Now that this patch has been reviewed, what is the next step?
> Thank you,
> Tim Myers

Interesting. The other patch is in my -next tree, and I plan to send a pull
request to Wim shortly. However, patchwork has no record of your patch.
Since I apply patches from patchwork, it effectively got lost. Please resend,
preferably with my Reviewed-by: tag.

Guenter

> 
>> ---
>> drivers/watchdog/booke_wdt.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
>> index 9d09bbfdef20..7817fb976f9c 100644
>> --- a/drivers/watchdog/booke_wdt.c
>> +++ b/drivers/watchdog/booke_wdt.c
>> @@ -39,6 +39,11 @@ static bool booke_wdt_enabled;
>> module_param(booke_wdt_enabled, bool, 0);
>> static int booke_wdt_period = CONFIG_BOOKE_WDT_DEFAULT_TIMEOUT;
>> module_param(booke_wdt_period, int, 0);
>> +static bool nowayout = WATCHDOG_NOWAYOUT;
>> +module_param(nowayout, bool, 0);
>> +MODULE_PARM_DESC(nowayout,
>> + "Watchdog cannot be stopped once started (default="
>> + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>>
>> #ifdef CONFIG_PPC_FSL_BOOK3E
>>
>> @@ -215,7 +220,6 @@ static void __exit booke_wdt_exit(void)
>> static int __init booke_wdt_init(void)
>> {
>> int ret = 0;
>> - bool nowayout = WATCHDOG_NOWAYOUT;
>>
>> pr_info("powerpc book-e watchdog driver loaded\n");
>> booke_wdt_info.firmware_version = cur_cpu_spec->pvr_value;
>>
>> base-commit: dd0d718152e4c65b173070d48ea9dfc06894c3e5
>> --
>> 2.20.1
>>
>>
>>
>> Timothy Myers
>> Software Design Engineer
>>
>> Office: 256.963.8844
>> Email: timothy.myers@adtran.com<https://owa.adtran.com/owa/redir.aspx?C=LNINRERj1VQgAKE9UNiu-b2J50yb_mKuK9OX8J4spjQqMzmAKlzUCA..&URL=mailto%3atom.patterson%40adtran.com <https://protect-us.mimecast.com/s/hhcoC73VkBhE3L6nFN4I06?domain=owa.adtran.com>>
>> Web: www.adtran.com <https://protect-us.mimecast.com/s/Fe38C82KlDFOn9MBFobOrH?domain=adtran.com><https://owa.adtran.com/owa/redir.aspx?C=AO4_0fpgN4Gmyy4bPe0sTxLKfRJry5Qrse3aJSw01zEqMzmAKlzUCA..&URL=http%3a%2f%2fs.bl-1.com%2fh%2fCoY1mz9%3furl%3dhttp%3a%2f%2fwww.adtran.com <https://protect-us.mimecast.com/s/pXgyC9rYmEuRo8KrU1uzSh?domain=owa.adtran.com>>
>>
>> ADTRAN
>> 901 Explorer Boulevard
>> Huntsville, AL 35806 - USA


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver
       [not found] <CH2PR19MB3590AFAC86BA1697956EAD1C9D690@CH2PR19MB3590.namprd19.prod.outlook.com>
@ 2020-07-06 15:10 ` Guenter Roeck
  0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2020-07-06 15:10 UTC (permalink / raw)
  To: Timothy Myers, Wim Van Sebroeck, linux-watchdog; +Cc: linux-kernel, David Boike

On 7/6/20 7:13 AM, Timothy Myers wrote:
> Add the common "nowayout" parameter to booke_wdt to make this behavior
> selectable at runtime and to make the implementation more consistent with
> many other watchdog drivers.
> 
> Signed-off-by: Timothy Myers <timothy.myers@adtran.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

The added Reviewed-by: makes it v2.

Anyway, your patch is whitespace corrupted.

ERROR: code indent should use tabs where possible
#36: FILE: drivers/watchdog/booke_wdt.c:45:
+               "Watchdog cannot be stopped once started (default="$

WARNING: please, no spaces at the start of a line
#36: FILE: drivers/watchdog/booke_wdt.c:45:
+               "Watchdog cannot be stopped once started (default="$

ERROR: code indent should use tabs where possible
#37: FILE: drivers/watchdog/booke_wdt.c:46:
+                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");$

WARNING: please, no spaces at the start of a line
#37: FILE: drivers/watchdog/booke_wdt.c:46:
+                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");$

That explains a lot. I guess it is corrupted so badly that patchwork
doesn't recognize it as patch. Sorry, won't be able to apply it.
Please send a non-corrupted version.

Guenter

> ---
>  drivers/watchdog/booke_wdt.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 9d09bbfdef20..7817fb976f9c 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -39,6 +39,11 @@ static bool booke_wdt_enabled;
>  module_param(booke_wdt_enabled, bool, 0);
>  static int  booke_wdt_period = CONFIG_BOOKE_WDT_DEFAULT_TIMEOUT;
>  module_param(booke_wdt_period, int, 0);
> +static bool nowayout = WATCHDOG_NOWAYOUT;
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout,
> +               "Watchdog cannot be stopped once started (default="
> +                               __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> 
>  #ifdef CONFIG_PPC_FSL_BOOK3E
> 
> @@ -215,7 +220,6 @@ static void __exit booke_wdt_exit(void)
>  static int __init booke_wdt_init(void)
>  {
>         int ret = 0;
> -       bool nowayout = WATCHDOG_NOWAYOUT;
> 
>         pr_info("powerpc book-e watchdog driver loaded\n");
>         booke_wdt_info.firmware_version = cur_cpu_spec->pvr_value;
> 
> base-commit: dd0d718152e4c65b173070d48ea9dfc06894c3e5
> --
> 2.20.1
> 
> 
> 
> *Timothy Myers*
> Software Design Engineer
> 
> Office: 256.963.8844
> 
> ADTRAN
> 901 Explorer Boulevard 
> Huntsville, AL 35806 - USA


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CH2PR19MB35903F8A6A46864C47A720029D930@CH2PR19MB3590.namprd19.prod.outlook.com>
2020-06-26 21:51 ` [PATCH 1/1] watchdog: Add common nowayout parameter to booke_wdt driver Guenter Roeck
     [not found]   ` <CH2PR19MB359071AAD5258D75F7255CA99D690@CH2PR19MB3590.namprd19.prod.outlook.com>
2020-07-06 13:51     ` Guenter Roeck
     [not found] <CH2PR19MB3590AFAC86BA1697956EAD1C9D690@CH2PR19MB3590.namprd19.prod.outlook.com>
2020-07-06 15:10 ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git