From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Lee Jones" <lee.jones@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Li Yang" <leoyang.li@nxp.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Pavel Machek" <pavel@ucw.cz>
Subject: Re: [PATCH v10 11/13] arm64: dts: freescale: sl28: enable LED support
Date: Tue, 22 Sep 2020 10:59:05 +0800 [thread overview]
Message-ID: <20200922025904.GX25109@dragon> (raw)
In-Reply-To: <20200914214341.14268-12-michael@walle.cc>
On Mon, Sep 14, 2020 at 11:43:39PM +0200, Michael Walle wrote:
> Now that we have support for GPIO lines of the SMARC connector, enable
> LED support on the KBox A-230-LS. There are two LEDs without fixed
> functions, one is yellow and one is green. Unfortunately, it is just one
> multi-color LED, thus while it is possible to enable both at the same
> time it is hard to tell the difference between "yellow only" and "yellow
> and green".
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> Changes since v9:
> - none
>
> Changes since v8:
> - none
>
> Changes since v7:
> - use new "function" and "color" properties instead of a label
> - added default-on trigger for the power-led
>
> Changes since v6:
> - none
>
> Changes since v5:
> - changed the label, suggested by Pavel Machek
>
> Changes since v4:
> - none
>
> Changes since v3:
> - see cover letter
>
> .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> index 4b4cc6a1573d..dd516c0efd8b 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> @@ -11,11 +11,29 @@
>
> /dts-v1/;
> #include "fsl-ls1028a-kontron-sl28-var4.dts"
> +#include <dt-bindings/leds/common.h>
>
> / {
> model = "Kontron KBox A-230-LS";
> compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var4",
> "kontron,sl28", "fsl,ls1028a";
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + alarm-led {
> + function = LED_FUNCTION_ALARM;
> + color = <LED_COLOR_ID_YELLOW>;
> + gpios = <&sl28cpld_gpio0 0 0>;
> + };
> +
> + power-led {
> + linux,default-trigger = "default-on";
> + function = LED_FUNCTION_POWER;
> + color = <LED_COLOR_ID_GREEN>;
> + gpios = <&sl28cpld_gpio1 3 0>;
Use GPIO_ACTIVE_HIGH for polarity to improve the readability.
I fixed them up and applied patch #9 ~ #13.
Shawn
> + };
> + };
> };
>
> &enetc_mdio_pf3 {
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-09-22 2:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 21:43 [PATCH v10 00/13] Add support for Kontron sl28cpld Michael Walle
2020-09-14 21:43 ` [PATCH v10 01/13] mfd: add simple regmap based I2C driver Michael Walle
2020-09-14 21:43 ` [PATCH v10 02/13] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-09-14 21:43 ` [PATCH v10 03/13] mfd: simple-mfd-i2c: add sl28cpld support Michael Walle
2020-09-14 21:43 ` [PATCH v10 04/13] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-09-14 21:43 ` [PATCH v10 05/13] watchdog: add support for sl28cpld watchdog Michael Walle
2020-09-14 21:43 ` [PATCH v10 06/13] pwm: add support for sl28cpld PWM controller Michael Walle
2020-09-15 9:06 ` Lee Jones
2020-09-15 21:03 ` Uwe Kleine-König
2020-09-14 21:43 ` [PATCH v10 07/13] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-09-14 21:43 ` [PATCH v10 08/13] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-09-14 21:43 ` [PATCH v10 09/13] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-09-14 21:43 ` [PATCH v10 10/13] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-09-14 21:43 ` [PATCH v10 11/13] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-09-22 2:59 ` Shawn Guo [this message]
2020-09-14 21:43 ` [PATCH v10 12/13] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-09-14 21:43 ` [PATCH v10 13/13] arm64: defconfig: enable the sl28cpld board management controller Michael Walle
2020-09-14 21:50 ` [PATCH v10 00/13] Add support for Kontron sl28cpld Michael Walle
2020-09-17 19:25 ` [GIT PULL] Immutable branch between MFD, HWMON, GPIO, IRQChip, PWM and Watchdog due for the v5.10 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922025904.GX25109@dragon \
--to=shawnguo@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=michael@walle.cc \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).