* [PATCH] watchdog: remove unneeded break
@ 2020-10-19 17:53 trix
2020-10-19 19:52 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-19 17:53 UTC (permalink / raw)
To: wim, linux; +Cc: linux-watchdog, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/watchdog/geodewdt.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/watchdog/geodewdt.c b/drivers/watchdog/geodewdt.c
index 83418924e30a..0b699c783d57 100644
--- a/drivers/watchdog/geodewdt.c
+++ b/drivers/watchdog/geodewdt.c
@@ -150,8 +150,6 @@ static long geodewdt_ioctl(struct file *file, unsigned int cmd,
case WDIOC_GETSUPPORT:
return copy_to_user(argp, &ident,
sizeof(ident)) ? -EFAULT : 0;
- break;
-
case WDIOC_GETSTATUS:
case WDIOC_GETBOOTSTATUS:
return put_user(0, p);
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: remove unneeded break
2020-10-19 17:53 [PATCH] watchdog: remove unneeded break trix
@ 2020-10-19 19:52 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-10-19 19:52 UTC (permalink / raw)
To: trix; +Cc: wim, linux-watchdog, linux-kernel
On Mon, Oct 19, 2020 at 10:53:42AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/geodewdt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/watchdog/geodewdt.c b/drivers/watchdog/geodewdt.c
> index 83418924e30a..0b699c783d57 100644
> --- a/drivers/watchdog/geodewdt.c
> +++ b/drivers/watchdog/geodewdt.c
> @@ -150,8 +150,6 @@ static long geodewdt_ioctl(struct file *file, unsigned int cmd,
> case WDIOC_GETSUPPORT:
> return copy_to_user(argp, &ident,
> sizeof(ident)) ? -EFAULT : 0;
> - break;
> -
> case WDIOC_GETSTATUS:
> case WDIOC_GETBOOTSTATUS:
> return put_user(0, p);
> --
> 2.18.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 17:53 [PATCH] watchdog: remove unneeded break trix
2020-10-19 19:52 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).