* [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles
@ 2020-10-29 16:21 Krzysztof Kozlowski
2020-10-29 16:21 ` [PATCH v2 2/2] ARM: dts: freescale: align watchdog node name with dtschema Krzysztof Kozlowski
2020-10-30 0:38 ` [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-29 16:21 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Li Yang, Anson Huang, linux-watchdog, devicetree,
linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski, Rob Herring
Document all ARMv5, ARMv6, ARMv7 and ARMv8 NXP (i.MX, Layerscape)
compatibles used in DTSes (even though driver binds only to
fsl,imx21-wdt) to fix dtbs_check warnings like:
arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:
['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes since v1:
1. Add also Layerscape,
2. Add Rob's review tag.
---
.../bindings/watchdog/fsl-imx-wdt.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 991b4e33486e..fb7695515be1 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -18,10 +18,26 @@ properties:
- const: fsl,imx21-wdt
- items:
- enum:
+ - fsl,imx25-wdt
+ - fsl,imx27-wdt
+ - fsl,imx31-wdt
+ - fsl,imx35-wdt
+ - fsl,imx50-wdt
+ - fsl,imx51-wdt
+ - fsl,imx53-wdt
+ - fsl,imx6q-wdt
+ - fsl,imx6sl-wdt
+ - fsl,imx6sll-wdt
+ - fsl,imx6sx-wdt
+ - fsl,imx6ul-wdt
+ - fsl,imx7d-wdt
- fsl,imx8mm-wdt
- fsl,imx8mn-wdt
- fsl,imx8mp-wdt
- fsl,imx8mq-wdt
+ - fsl,ls1012a-wdt
+ - fsl,ls1043a-wdt
+ - fsl,vf610-wdt
- const: fsl,imx21-wdt
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] ARM: dts: freescale: align watchdog node name with dtschema
2020-10-29 16:21 [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles Krzysztof Kozlowski
@ 2020-10-29 16:21 ` Krzysztof Kozlowski
2020-10-30 0:40 ` Shawn Guo
2020-10-30 0:38 ` [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-29 16:21 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Li Yang, Anson Huang, linux-watchdog, devicetree,
linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
The dtschema expects watchdog device node name to be "watchdog":
arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dt.yaml: wdog@2ad0000:
$nodename:0: 'wdog@2ad0000' does not match '^watchdog(@.*|-[0-9a-f])?$'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v1:
1. New patch
---
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 2 +-
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index 6a2c09199047..1393fc7e56bb 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -401,7 +401,7 @@ gpio1: gpio@2310000 {
#interrupt-cells = <2>;
};
- wdog0: wdog@2ad0000 {
+ wdog0: watchdog@2ad0000 {
compatible = "fsl,ls1012a-wdt",
"fsl,imx21-wdt";
reg = <0x0 0x2ad0000 0x0 0x10000>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 0464b8aa4bc4..d550f00f1f6a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -725,7 +725,7 @@ lpuart5: serial@29a0000 {
status = "disabled";
};
- wdog0: wdog@2ad0000 {
+ wdog0: watchdog@2ad0000 {
compatible = "fsl,ls1043a-wdt", "fsl,imx21-wdt";
reg = <0x0 0x2ad0000 0x0 0x10000>;
interrupts = <0 83 0x4>;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles
2020-10-29 16:21 [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles Krzysztof Kozlowski
2020-10-29 16:21 ` [PATCH v2 2/2] ARM: dts: freescale: align watchdog node name with dtschema Krzysztof Kozlowski
@ 2020-10-30 0:38 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-10-30 0:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Li Yang,
Anson Huang, linux-watchdog, devicetree, linux-arm-kernel,
linux-kernel, Rob Herring
On Thu, Oct 29, 2020 at 05:21:32PM +0100, Krzysztof Kozlowski wrote:
> Document all ARMv5, ARMv6, ARMv7 and ARMv8 NXP (i.MX, Layerscape)
> compatibles used in DTSes (even though driver binds only to
> fsl,imx21-wdt) to fix dtbs_check warnings like:
>
> arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:
> ['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: freescale: align watchdog node name with dtschema
2020-10-29 16:21 ` [PATCH v2 2/2] ARM: dts: freescale: align watchdog node name with dtschema Krzysztof Kozlowski
@ 2020-10-30 0:40 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-10-30 0:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Li Yang,
Anson Huang, linux-watchdog, devicetree, linux-arm-kernel,
linux-kernel
On Thu, Oct 29, 2020 at 05:21:33PM +0100, Krzysztof Kozlowski wrote:
> The dtschema expects watchdog device node name to be "watchdog":
>
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dt.yaml: wdog@2ad0000:
> $nodename:0: 'wdog@2ad0000' does not match '^watchdog(@.*|-[0-9a-f])?$'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
s/ARM/arm64 in subject.
I fixed it up and applied the patch.
Shawn
>
> ---
>
> Changes since v1:
> 1. New patch
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-30 0:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 16:21 [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles Krzysztof Kozlowski
2020-10-29 16:21 ` [PATCH v2 2/2] ARM: dts: freescale: align watchdog node name with dtschema Krzysztof Kozlowski
2020-10-30 0:40 ` Shawn Guo
2020-10-30 0:38 ` [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).