* Re: [PATCH v3 17/21] dt-bindings: watchdog: sun4i: Add H616 compatible string
2021-01-18 2:08 ` [PATCH v3 17/21] dt-bindings: watchdog: sun4i: Add H616 compatible string Andre Przywara
@ 2021-01-18 15:34 ` maxime
2021-01-23 17:31 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: maxime @ 2021-01-18 15:34 UTC (permalink / raw)
To: Andre Przywara
Cc: Chen-Yu Tsai, Jernej Skrabec, Icenowy Zheng, Linus Walleij,
Rob Herring, Clément Péron, Samuel Holland,
Shuosheng Huang, Yangtao Li, linux-arm-kernel, linux-kernel,
linux-sunxi, Guenter Roeck, Wim Van Sebroeck, devicetree,
linux-watchdog
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
On Mon, Jan 18, 2021 at 02:08:44AM +0000, Andre Przywara wrote:
> Use enums to group all compatible devices together on the way.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 17/21] dt-bindings: watchdog: sun4i: Add H616 compatible string
2021-01-18 2:08 ` [PATCH v3 17/21] dt-bindings: watchdog: sun4i: Add H616 compatible string Andre Przywara
2021-01-18 15:34 ` maxime
@ 2021-01-23 17:31 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-01-23 17:31 UTC (permalink / raw)
To: Andre Przywara
Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, Icenowy Zheng,
Linus Walleij, Rob Herring, Clément Péron,
Samuel Holland, Shuosheng Huang, Yangtao Li, linux-arm-kernel,
linux-kernel, linux-sunxi, Wim Van Sebroeck, devicetree,
linux-watchdog
On Mon, Jan 18, 2021 at 02:08:44AM +0000, Andre Przywara wrote:
> Use enums to group all compatible devices together on the way.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> .../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> index 5ac607de8be4..9aa3c313c49f 100644
> --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> @@ -19,13 +19,11 @@ properties:
> - const: allwinner,sun4i-a10-wdt
> - const: allwinner,sun6i-a31-wdt
> - items:
> - - const: allwinner,sun50i-a64-wdt
> - - const: allwinner,sun6i-a31-wdt
> - - items:
> - - const: allwinner,sun50i-a100-wdt
> - - const: allwinner,sun6i-a31-wdt
> - - items:
> - - const: allwinner,sun50i-h6-wdt
> + - enum:
> + - allwinner,sun50i-a64-wdt
> + - allwinner,sun50i-a100-wdt
> + - allwinner,sun50i-h6-wdt
> + - allwinner,sun50i-h616-wdt
> - const: allwinner,sun6i-a31-wdt
> - items:
> - const: allwinner,suniv-f1c100s-wdt
^ permalink raw reply [flat|nested] 3+ messages in thread