From: mark gross <mgross@linux.intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Saravana Kannan <saravanak@google.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Joerg Roedel <jroedel@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-hwmon@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] Add managed version of delayed work init
Date: Thu, 18 Feb 2021 08:28:21 -0800 [thread overview]
Message-ID: <20210218162821.GP154917@linux.intel.com> (raw)
In-Reply-To: <cover.1613216412.git.matti.vaittinen@fi.rohmeurope.com>
On Sat, Feb 13, 2021 at 01:58:17PM +0200, Matti Vaittinen wrote:
> It's not rare that device drivers need delayed work.
> It's not rare that this work needs driver's data.
>
> Often this means that driver must ensure the work is not queued when
> driver exits. Usually this is done by ensuring new work is not added and
> then calling cancel_delayed_work_sync() at remove(). In many cases this
> may also require cleanup at probe error path - which is easy to forget.
>
> It might be helpful for (a) few drivers if there was a work init
why the (a) and not just a?
> function which would ensure cancel_delayed_work_sync() is called at
> driver exit. So this series implements one on top of devm and replaces
> the obvious cases where only thing remove call-back in a driver does is
> cancelling the work. There might be other cases where we could switch
> more than just work cancellation to use managed version and thus get rid
> of remove.
>
> Main reson why this is RFC is that I had hard time deciding where this
> function should be introduced. It's not nice to include all device stuff
> in workqueue - because many workqueue users are not interested in
> devices. In same way, not all of the devices are interested in WQs.
> OTOH, adding own file just for this sounds like an overkill.
s/own/one
--mark
>
> This time I decided that it is more correct that devices use WQs than
> that WQs use devices. Hence the function is introduced in
> include/linux/device.h and drivers/base/devres.c
>
> --
>
> Matti Vaittinen (7):
> drivers: base: Add resource managed version of delayed work init
> extconn: Clean-up few drivers by using managed work init
> hwmon: raspberry-pi: Clean-up few drivers by using managed work init
> platform/x86: gpd pocket fan: Clean-up by using managed work init
> power: supply: Clean-up few drivers by using managed work init
> regulator: qcom_spmi-regulator: Clean-up by using managed work init
> watchdog: retu_wdt: Clean-up by using managed work init
>
> drivers/base/devres.c | 33 ++++++++++++++++++++
> drivers/extcon/extcon-gpio.c | 14 ++-------
> drivers/extcon/extcon-intel-int3496.c | 15 ++-------
> drivers/extcon/extcon-palmas.c | 16 +++-------
> drivers/extcon/extcon-qcom-spmi-misc.c | 16 +++-------
> drivers/hwmon/raspberrypi-hwmon.c | 16 +++-------
> drivers/platform/x86/gpd-pocket-fan.c | 16 +++-------
> drivers/power/supply/axp20x_usb_power.c | 15 +++------
> drivers/power/supply/bq24735-charger.c | 17 +++-------
> drivers/power/supply/ltc2941-battery-gauge.c | 19 ++++-------
> drivers/power/supply/sbs-battery.c | 15 +++------
> drivers/regulator/qcom_spmi-regulator.c | 33 +++++---------------
> drivers/watchdog/retu_wdt.c | 21 +++----------
> include/linux/device.h | 5 +++
> 14 files changed, 95 insertions(+), 156 deletions(-)
>
>
> base-commit: 92bf22614b21a2706f4993b278017e437f7785b3
> --
> 2.25.4
>
>
> --
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
>
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]
next prev parent reply other threads:[~2021-02-18 18:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 11:58 [RFC PATCH 0/7] Add managed version of delayed work init Matti Vaittinen
2021-02-13 11:58 ` [RFC PATCH 1/7] drivers: base: Add resource " Matti Vaittinen
2021-02-13 12:16 ` Greg Kroah-Hartman
2021-02-13 12:26 ` Vaittinen, Matti
2021-02-13 12:38 ` gregkh
2021-02-13 13:18 ` Hans de Goede
2021-02-13 13:33 ` Greg Kroah-Hartman
2021-02-13 14:38 ` Hans de Goede
2021-02-13 14:52 ` Hans de Goede
2021-02-15 6:58 ` Matti Vaittinen
2021-02-13 15:03 ` Hans de Goede
2021-02-13 15:27 ` Guenter Roeck
2021-02-13 15:59 ` Hans de Goede
2021-02-13 18:17 ` Guenter Roeck
2021-02-15 7:22 ` Vaittinen, Matti
2021-02-15 10:37 ` Hans de Goede
2021-02-15 11:31 ` gregkh
2021-02-15 11:43 ` Hans de Goede
2021-02-15 13:12 ` Vaittinen, Matti
2021-02-13 12:18 ` [RFC PATCH 7/7] watchdog: retu_wdt: Clean-up by using managed " Matti Vaittinen
2021-02-18 16:28 ` mark gross [this message]
2021-02-19 10:35 ` [RFC PATCH 0/7] Add managed version of delayed " Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218162821.GP154917@linux.intel.com \
--to=mgross@linux.intel.com \
--cc=agross@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jroedel@suse.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).