* [PATCH] watchdog: rti-wdt: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07 7:42 Cai Huoqing
2021-09-07 12:40 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-09-07 7:42 UTC (permalink / raw)
To: caihuoqing; +Cc: Wim Van Sebroeck, Guenter Roeck, linux-watchdog, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/watchdog/rti_wdt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
index 359302f71f7e..117bc2a8eb0a 100644
--- a/drivers/watchdog/rti_wdt.c
+++ b/drivers/watchdog/rti_wdt.c
@@ -194,7 +194,6 @@ static int rti_wdt_probe(struct platform_device *pdev)
{
int ret = 0;
struct device *dev = &pdev->dev;
- struct resource *wdt_mem;
struct watchdog_device *wdd;
struct rti_wdt_device *wdt;
struct clk *clk;
@@ -246,8 +245,7 @@ static int rti_wdt_probe(struct platform_device *pdev)
watchdog_set_nowayout(wdd, 1);
watchdog_set_restart_priority(wdd, 128);
- wdt_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- wdt->base = devm_ioremap_resource(dev, wdt_mem);
+ wdt->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(wdt->base)) {
ret = PTR_ERR(wdt->base);
goto err_iomap;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] watchdog: rti-wdt: Make use of the helper function devm_platform_ioremap_resource()
2021-09-07 7:42 [PATCH] watchdog: rti-wdt: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-07 12:40 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-09-07 12:40 UTC (permalink / raw)
To: Cai Huoqing; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel
On Tue, Sep 07, 2021 at 03:42:36PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/rti_wdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index 359302f71f7e..117bc2a8eb0a 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -194,7 +194,6 @@ static int rti_wdt_probe(struct platform_device *pdev)
> {
> int ret = 0;
> struct device *dev = &pdev->dev;
> - struct resource *wdt_mem;
> struct watchdog_device *wdd;
> struct rti_wdt_device *wdt;
> struct clk *clk;
> @@ -246,8 +245,7 @@ static int rti_wdt_probe(struct platform_device *pdev)
> watchdog_set_nowayout(wdd, 1);
> watchdog_set_restart_priority(wdd, 128);
>
> - wdt_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - wdt->base = devm_ioremap_resource(dev, wdt_mem);
> + wdt->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(wdt->base)) {
> ret = PTR_ERR(wdt->base);
> goto err_iomap;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-07 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 7:42 [PATCH] watchdog: rti-wdt: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-07 12:40 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).