* [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC
@ 2023-03-20 10:45 Kathiravan T
2023-03-20 10:45 ` [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible Kathiravan T
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Kathiravan T @ 2023-03-20 10:45 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, wim, linux, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
Cc: Kathiravan T
This series adds the support for QUP peripherals, PRNG, WDT for IPQ5332
SoC.
This series depends on the below patch, due to the node ordering
https://lore.kernel.org/linux-arm-msm/20230217083308.12017-6-quic_kathirav@quicinc.com/#t
Kathiravan T (2):
dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible
arm64: dts: qcom: ipq5332: add few device nodes
.../bindings/watchdog/qcom-wdt.yaml | 1 +
arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 14 ++++
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 67 +++++++++++++++++++
3 files changed, 82 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible
2023-03-20 10:45 [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
@ 2023-03-20 10:45 ` Kathiravan T
2023-04-13 4:39 ` Kathiravan T
2023-04-16 15:43 ` Guenter Roeck
2023-03-20 10:45 ` [PATCH V2 2/2] arm64: dts: qcom: ipq5332: add few device nodes Kathiravan T
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: Kathiravan T @ 2023-03-20 10:45 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, wim, linux, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
Cc: Kathiravan T
Add a compatible for the IPQ5332 platform's APSS watchdog.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
- Pick up R-b tag
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 6448b633c970..8060a87d29da 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -18,6 +18,7 @@ properties:
- items:
- enum:
- qcom,kpss-wdt-ipq4019
+ - qcom,apss-wdt-ipq5332
- qcom,apss-wdt-msm8994
- qcom,apss-wdt-qcs404
- qcom,apss-wdt-sa8775p
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V2 2/2] arm64: dts: qcom: ipq5332: add few device nodes
2023-03-20 10:45 [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
2023-03-20 10:45 ` [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible Kathiravan T
@ 2023-03-20 10:45 ` Kathiravan T
2023-03-30 15:30 ` [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
2023-04-07 17:41 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Kathiravan T @ 2023-03-20 10:45 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, wim, linux, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
Cc: Kathiravan T
Add the nodes for QUP peripheral, PRNG and WDOG. While at it, enable the
I2C device for MI01.2 board.
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
- Moved the 'reg' property after compatible
arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 14 +++++
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 67 +++++++++++++++++++++
2 files changed, 81 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
index 702013b867d7..3af1d5556950 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
+++ b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
@@ -28,6 +28,13 @@
status = "okay";
};
+&blsp1_i2c1 {
+ clock-frequency = <400000>;
+ pinctrl-0 = <&i2c_1_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
&sdhc {
bus-width = <4>;
max-frequency = <192000000>;
@@ -50,6 +57,13 @@
/* PINCTRL */
&tlmm {
+ i2c_1_pins: i2c-1-state {
+ pins = "gpio29", "gpio30";
+ function = "blsp1_i2c0";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
sdc_default_state: sdc-default-state {
clk-pins {
pins = "gpio13";
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 04ef80f267bf..12e0e179e139 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -134,6 +134,13 @@
#size-cells = <1>;
ranges = <0 0 0 0xffffffff>;
+ rng: rng@e3000 {
+ compatible = "qcom,prng-ee";
+ reg = <0x000e3000 0x1000>;
+ clocks = <&gcc GCC_PRNG_AHB_CLK>;
+ clock-names = "core";
+ };
+
tlmm: pinctrl@1000000 {
compatible = "qcom,ipq5332-tlmm";
reg = <0x01000000 0x300000>;
@@ -191,6 +198,16 @@
status = "disabled";
};
+ blsp_dma: dma-controller@7884000 {
+ compatible = "qcom,bam-v1.7.0";
+ reg = <0x07884000 0x1d000>;
+ interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GCC_BLSP1_AHB_CLK>;
+ clock-names = "bam_clk";
+ #dma-cells = <1>;
+ qcom,ee = <0>;
+ };
+
blsp1_uart0: serial@78af000 {
compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
reg = <0x078af000 0x200>;
@@ -201,6 +218,48 @@
status = "disabled";
};
+ blsp1_spi0: spi@78b5000 {
+ compatible = "qcom,spi-qup-v2.2.1";
+ reg = <0x078b5000 0x600>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GCC_BLSP1_QUP1_SPI_APPS_CLK>,
+ <&gcc GCC_BLSP1_AHB_CLK>;
+ clock-names = "core", "iface";
+ dmas = <&blsp_dma 4>, <&blsp_dma 5>;
+ dma-names = "tx", "rx";
+ status = "disabled";
+ };
+
+ blsp1_i2c1: i2c@78b6000 {
+ compatible = "qcom,i2c-qup-v2.2.1";
+ reg = <0x078b6000 0x600>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>,
+ <&gcc GCC_BLSP1_AHB_CLK>;
+ clock-names = "core", "iface";
+ dmas = <&blsp_dma 6>, <&blsp_dma 7>;
+ dma-names = "tx", "rx";
+ status = "disabled";
+ };
+
+ blsp1_spi2: spi@78b7000 {
+ compatible = "qcom,spi-qup-v2.2.1";
+ reg = <0x078b7000 0x600>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GCC_BLSP1_QUP3_SPI_APPS_CLK>,
+ <&gcc GCC_BLSP1_AHB_CLK>;
+ clock-names = "core", "iface";
+ dmas = <&blsp_dma 8>, <&blsp_dma 9>;
+ dma-names = "tx", "rx";
+ status = "disabled";
+ };
+
intc: interrupt-controller@b000000 {
compatible = "qcom,msm-qgic2";
reg = <0x0b000000 0x1000>, /* GICD */
@@ -233,6 +292,14 @@
};
};
+ watchdog: watchdog@b017000 {
+ compatible = "qcom,apss-wdt-ipq5332", "qcom,kpss-wdt";
+ reg = <0x0b017000 0x1000>;
+ interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&sleep_clk>;
+ timeout-sec = <30>;
+ };
+
apcs_glb: mailbox@b111000 {
compatible = "qcom,ipq5332-apcs-apps-global",
"qcom,ipq6018-apcs-apps-global";
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC
2023-03-20 10:45 [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
2023-03-20 10:45 ` [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible Kathiravan T
2023-03-20 10:45 ` [PATCH V2 2/2] arm64: dts: qcom: ipq5332: add few device nodes Kathiravan T
@ 2023-03-30 15:30 ` Kathiravan T
2023-04-07 17:41 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Kathiravan T @ 2023-03-30 15:30 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, wim, linux, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
On 3/20/2023 4:15 PM, Kathiravan T wrote:
> This series adds the support for QUP peripherals, PRNG, WDT for IPQ5332
> SoC.
>
> This series depends on the below patch, due to the node ordering
> https://lore.kernel.org/linux-arm-msm/20230217083308.12017-6-quic_kathirav@quicinc.com/#t
Gentle Reminder...
>
> Kathiravan T (2):
> dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible
> arm64: dts: qcom: ipq5332: add few device nodes
>
> .../bindings/watchdog/qcom-wdt.yaml | 1 +
> arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 14 ++++
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 67 +++++++++++++++++++
> 3 files changed, 82 insertions(+)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC
2023-03-20 10:45 [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
` (2 preceding siblings ...)
2023-03-30 15:30 ` [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
@ 2023-04-07 17:41 ` Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2023-04-07 17:41 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, linux, wim, robh+dt, agross,
linux-kernel, Kathiravan T, konrad.dybcio, linux-watchdog,
devicetree, linux-arm-msm
On Mon, 20 Mar 2023 16:15:28 +0530, Kathiravan T wrote:
> This series adds the support for QUP peripherals, PRNG, WDT for IPQ5332
> SoC.
>
> This series depends on the below patch, due to the node ordering
> https://lore.kernel.org/linux-arm-msm/20230217083308.12017-6-quic_kathirav@quicinc.com/#t
>
> Kathiravan T (2):
> dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible
> arm64: dts: qcom: ipq5332: add few device nodes
>
> [...]
Applied, thanks!
[2/2] arm64: dts: qcom: ipq5332: add few device nodes
commit: d0367098dc1e925d22a6706e358636d12371116c
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible
2023-03-20 10:45 ` [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible Kathiravan T
@ 2023-04-13 4:39 ` Kathiravan T
2023-04-16 10:19 ` Krzysztof Kozlowski
2023-04-16 15:43 ` Guenter Roeck
1 sibling, 1 reply; 8+ messages in thread
From: Kathiravan T @ 2023-04-13 4:39 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, wim, linux, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
On 3/20/2023 4:15 PM, Kathiravan T wrote:
> Add a compatible for the IPQ5332 platform's APSS watchdog.
Guenter,
Without this patch, I see dtbs_check failure in linux-next.
I see you reviewed the V1 of this patch, can you pick up this patch? I don't see it in https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/log/?h=watchdog-next
I'm not sure if I am looking at the right tree, Please correct me if I am wrong.
Thanks,
Kathiravan T.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> - Pick up R-b tag
>
> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 6448b633c970..8060a87d29da 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -18,6 +18,7 @@ properties:
> - items:
> - enum:
> - qcom,kpss-wdt-ipq4019
> + - qcom,apss-wdt-ipq5332
> - qcom,apss-wdt-msm8994
> - qcom,apss-wdt-qcs404
> - qcom,apss-wdt-sa8775p
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible
2023-04-13 4:39 ` Kathiravan T
@ 2023-04-16 10:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-16 10:19 UTC (permalink / raw)
To: Kathiravan T, agross, andersson, konrad.dybcio, wim, linux,
robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
On 13/04/2023 06:39, Kathiravan T wrote:
>
> On 3/20/2023 4:15 PM, Kathiravan T wrote:
>> Add a compatible for the IPQ5332 platform's APSS watchdog.
>
> Guenter,
>
>
> Without this patch, I see dtbs_check failure in linux-next.
>
>
> I see you reviewed the V1 of this patch, can you pick up this patch? I don't see it in https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/log/?h=watchdog-next
> I'm not sure if I am looking at the right tree, Please correct me if I am wrong.
Are you sure that patch still applies?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible
2023-03-20 10:45 ` [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible Kathiravan T
2023-04-13 4:39 ` Kathiravan T
@ 2023-04-16 15:43 ` Guenter Roeck
1 sibling, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2023-04-16 15:43 UTC (permalink / raw)
To: Kathiravan T
Cc: agross, andersson, konrad.dybcio, wim, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
On Mon, Mar 20, 2023 at 04:15:29PM +0530, Kathiravan T wrote:
> Add a compatible for the IPQ5332 platform's APSS watchdog.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changes in V2:
> - Pick up R-b tag
>
> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 6448b633c970..8060a87d29da 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -18,6 +18,7 @@ properties:
> - items:
> - enum:
> - qcom,kpss-wdt-ipq4019
> + - qcom,apss-wdt-ipq5332
> - qcom,apss-wdt-msm8994
> - qcom,apss-wdt-qcs404
> - qcom,apss-wdt-sa8775p
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-04-16 15:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 10:45 [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
2023-03-20 10:45 ` [PATCH V2 1/2] dt-bindings: watchdog: qcom-wdt: add qcom,apss-wdt-ipq5332 compatible Kathiravan T
2023-04-13 4:39 ` Kathiravan T
2023-04-16 10:19 ` Krzysztof Kozlowski
2023-04-16 15:43 ` Guenter Roeck
2023-03-20 10:45 ` [PATCH V2 2/2] arm64: dts: qcom: ipq5332: add few device nodes Kathiravan T
2023-03-30 15:30 ` [PATCH V2 0/2] Add few device nodes for IPQ5332 SoC Kathiravan T
2023-04-07 17:41 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).