* Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
[not found] ` <20191227141405.3396-2-yong.liang@mediatek.com>
@ 2020-01-08 8:56 ` Nicolas Boichat
2020-01-08 9:14 ` Nicolas Boichat
0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Boichat @ 2020-01-08 8:56 UTC (permalink / raw)
To: Yong Liang
Cc: Matthias Brugger, linux-arm Mailing List,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Mark Rutland, Devicetree List, lkml, wim, linux, linux-watchdog
minor nit, s/amr64/arm64/ in the commit title.
On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
>
> From: "yong.liang" <yong.liang@mediatek.com>
>
> 1. Include mt8183-reset.h and add reset-cells in infracfg
> in dtsi file
> 2. Add watchdog device node
>
> Signed-off-by: yong.liang <yong.liang@mediatek.com>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
> [snip]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: mt8183: Add watchdog dt-binding
[not found] ` <20191227141405.3396-3-yong.liang@mediatek.com>
@ 2020-01-08 8:57 ` Nicolas Boichat
2020-01-08 10:59 ` Matthias Brugger
0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Boichat @ 2020-01-08 8:57 UTC (permalink / raw)
To: Yong Liang
Cc: Matthias Brugger, linux-arm Mailing List,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Mark Rutland, Devicetree List, lkml, wim, linux, linux-watchdog
Looks trivial.
On Fri, Dec 27, 2019 at 10:25 PM Yong Liang <yong.liang@mediatek.com> wrote:
>
> From: "yong.liang" <yong.liang@mediatek.com>
>
> This patch add watchdog binding documentation for
> watchdog on MTK Socs.
>
> Signed-off-by: yong.liang <yong.liang@mediatek.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index fd380eb28df5..3ee625d0812f 100644
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -9,6 +9,7 @@ Required properties:
> "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> + "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>
> - reg : Specifies base physical address and size of the registers.
> --
> 2.18.0
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
2020-01-08 8:56 ` [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi Nicolas Boichat
@ 2020-01-08 9:14 ` Nicolas Boichat
2020-01-09 3:59 ` Yong Liang
2020-01-10 10:09 ` Matthias Brugger
0 siblings, 2 replies; 9+ messages in thread
From: Nicolas Boichat @ 2020-01-08 9:14 UTC (permalink / raw)
To: Yong Liang
Cc: Matthias Brugger, linux-arm Mailing List,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Mark Rutland, Devicetree List, lkml, wim, linux, linux-watchdog
On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>
> minor nit, s/amr64/arm64/ in the commit title.
>
> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
> >
> > From: "yong.liang" <yong.liang@mediatek.com>
> >
> > 1. Include mt8183-reset.h and add reset-cells in infracfg
> > in dtsi file
Err, wait, doesn't this depend on
http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
?
> > 2. Add watchdog device node
Can we have a patch with just this change instead, since you're
sending the binding with it.
> >
> > Signed-off-by: yong.liang <yong.liang@mediatek.com>
>
> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> > [snip]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: mt8183: Add watchdog dt-binding
2020-01-08 8:57 ` [PATCH v3 2/2] dt-bindings: mt8183: Add watchdog dt-binding Nicolas Boichat
@ 2020-01-08 10:59 ` Matthias Brugger
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2020-01-08 10:59 UTC (permalink / raw)
To: Nicolas Boichat, Yong Liang
Cc: linux-arm Mailing List, moderated list:ARM/Mediatek SoC support,
Rob Herring, Mark Rutland, Devicetree List, lkml, wim, linux,
linux-watchdog
On 08/01/2020 09:57, Nicolas Boichat wrote:
> Looks trivial.
>
> On Fri, Dec 27, 2019 at 10:25 PM Yong Liang <yong.liang@mediatek.com> wrote:
>>
>> From: "yong.liang" <yong.liang@mediatek.com>
>>
>> This patch add watchdog binding documentation for
>> watchdog on MTK Socs.
>>
>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>
> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
>
Wim, Guenter, will you take this one through your tree or shall I take it?
Regards,
Matthias
>> ---
>> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> index fd380eb28df5..3ee625d0812f 100644
>> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> @@ -9,6 +9,7 @@ Required properties:
>> "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
>> "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
>> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
>> + "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
>> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>>
>> - reg : Specifies base physical address and size of the registers.
>> --
>> 2.18.0
>> _______________________________________________
>> Linux-mediatek mailing list
>> Linux-mediatek@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
2020-01-08 9:14 ` Nicolas Boichat
@ 2020-01-09 3:59 ` Yong Liang
2020-01-10 10:09 ` Matthias Brugger
1 sibling, 0 replies; 9+ messages in thread
From: Yong Liang @ 2020-01-09 3:59 UTC (permalink / raw)
To: Nicolas Boichat
Cc: Mark Rutland, Devicetree List, linux-watchdog, lkml, Rob Herring,
moderated list:ARM/Mediatek SoC support, linux, Matthias Brugger,
wim, linux-arm Mailing List
On Wed, 2020-01-08 at 17:14 +0800, Nicolas Boichat wrote:
> On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
> >
> > minor nit, s/amr64/arm64/ in the commit title.
> >
> > On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
> > >
> > > From: "yong.liang" <yong.liang@mediatek.com>
> > >
> > > 1. Include mt8183-reset.h and add reset-cells in infracfg
> > > in dtsi file
>
> Err, wait, doesn't this depend on
> http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> ?
>
Yes, but this patch can be delay a while, We will ensure jiaxin's
patch be send out prioritly.
Yong.Liang
> > > 2. Add watchdog device node
>
> Can we have a patch with just this change instead, since you're
> sending the binding with it.
I will remove binding txt file from this patch.
And we will ensure jiaxin's patch be send out prioritly.
>
> > >
> > > Signed-off-by: yong.liang <yong.liang@mediatek.com>
> >
> > Tested-by: Nicolas Boichat <drinkcat@chromium.org>
> >
> > > ---
> > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > > [snip]
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
2020-01-08 9:14 ` Nicolas Boichat
2020-01-09 3:59 ` Yong Liang
@ 2020-01-10 10:09 ` Matthias Brugger
2020-01-13 4:44 ` Nicolas Boichat
1 sibling, 1 reply; 9+ messages in thread
From: Matthias Brugger @ 2020-01-10 10:09 UTC (permalink / raw)
To: Nicolas Boichat, Yong Liang
Cc: linux-arm Mailing List, moderated list:ARM/Mediatek SoC support,
Rob Herring, Mark Rutland, Devicetree List, lkml, wim, linux,
linux-watchdog
On 08/01/2020 10:14, Nicolas Boichat wrote:
> On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>>
>> minor nit, s/amr64/arm64/ in the commit title.
>>
>> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
>>>
>>> From: "yong.liang" <yong.liang@mediatek.com>
>>>
>>> 1. Include mt8183-reset.h and add reset-cells in infracfg
>>> in dtsi file
>
> Err, wait, doesn't this depend on
> http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> ?
>
That's all a bit confusing, I thought we are fine to add the reset cells to
infracfg as we have the resets defined in
64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
That's why I took this part from:
https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
Please let me know if I'm wrong and I'll drop it.
Regards,
Matthias
>>> 2. Add watchdog device node
>
> Can we have a patch with just this change instead, since you're
> sending the binding with it.
>
>>>
>>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>>
>> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>> [snip]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
2020-01-10 10:09 ` Matthias Brugger
@ 2020-01-13 4:44 ` Nicolas Boichat
2020-01-13 6:27 ` Nicolas Boichat
0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Boichat @ 2020-01-13 4:44 UTC (permalink / raw)
To: Matthias Brugger
Cc: Yong Liang, linux-arm Mailing List,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Mark Rutland, Devicetree List, lkml, wim, linux, linux-watchdog
On Fri, Jan 10, 2020 at 6:09 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 08/01/2020 10:14, Nicolas Boichat wrote:
> > On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
> >>
> >> minor nit, s/amr64/arm64/ in the commit title.
> >>
> >> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
> >>>
> >>> From: "yong.liang" <yong.liang@mediatek.com>
> >>>
> >>> 1. Include mt8183-reset.h and add reset-cells in infracfg
> >>> in dtsi file
> >
> > Err, wait, doesn't this depend on
> > http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> > ?
> >
>
> That's all a bit confusing, I thought we are fine to add the reset cells to
> infracfg as we have the resets defined in
> 64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
You're right, we're fine. But at least in theory, we should still have
the binding documentation that I linked above.
I will try to pick up all the required patches, split them across
8183/2712 and resend as one series.
> That's why I took this part from:
> https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
>
> Please let me know if I'm wrong and I'll drop it.
>
> Regards,
> Matthias
>
> >>> 2. Add watchdog device node
> >
> > Can we have a patch with just this change instead, since you're
> > sending the binding with it.
> >
> >>>
> >>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
> >>
> >> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
> >>
> >>> ---
> >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
> >>> 1 file changed, 8 insertions(+)
> >>> [snip]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
2020-01-13 4:44 ` Nicolas Boichat
@ 2020-01-13 6:27 ` Nicolas Boichat
2020-01-13 9:41 ` Yong Liang
0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Boichat @ 2020-01-13 6:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Yong Liang, linux-arm Mailing List,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Mark Rutland, Devicetree List, lkml, wim, linux, linux-watchdog,
Jiaxin Yu, Sj Huang
+Jiaxin +Sj Huang
On Mon, Jan 13, 2020 at 12:44 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>
> On Fri, Jan 10, 2020 at 6:09 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > [snip]
> > That's all a bit confusing, I thought we are fine to add the reset cells to
> > infracfg as we have the resets defined in
> > 64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
>
> You're right, we're fine. But at least in theory, we should still have
> the binding documentation that I linked above.
>
> I will try to pick up all the required patches, split them across
> 8183/2712 and resend as one series.
Okay, summary of the patches, there are 2 series:
https://patchwork.kernel.org/patch/11311237/
[1.1] [v3,1/2] amr64: dts: modify mt8183.dtsi
=> Partially applied to Matthias' v5.5-next/dts64
=> Other part depend on [1.2], needs to be applied
https://patchwork.kernel.org/patch/11311241/
[1.2] [v3,2/2] dt-bindings: mt8183: Add watchdog dt-binding
=> Pending Guenter/Wim
https://patchwork.kernel.org/cover/11326757/
[2.0] [PATCH v11 0/3] ASoC: mt8183: fix audio playback slowly after playback
[2.1] [PATCH v11 1/3] dt-bindings: mediatek: mt8183: Add #reset-cells
=> IMHO adding mt2712 compatible should be another patch
=> Depends on [1.2]
=> Tags should be all dropped
[2.2] [PATCH v11 2/3] watchdog: mtk_wdt: mt8183: Add reset controller
=> Issues about tags
[2.3] [PATCH v11 3/3] watchdog: mtk_wdt: mt2712: Add reset controller
=> Issues about tags
Jiaxin/Yong Liang/Matthias: Please let me know, I'm happy to pick up
the patches, clean them up and resend them, if you think that helps.
> > That's why I took this part from:
> > https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
> >
> > Please let me know if I'm wrong and I'll drop it.
> >
> > Regards,
> > Matthias
> >
> > >>> 2. Add watchdog device node
> > >
> > > Can we have a patch with just this change instead, since you're
> > > sending the binding with it.
> > >
> > >>>
> > >>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
> > >>
> > >> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
> > >>
> > >>> ---
> > >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
> > >>> 1 file changed, 8 insertions(+)
> > >>> [snip]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
2020-01-13 6:27 ` Nicolas Boichat
@ 2020-01-13 9:41 ` Yong Liang
0 siblings, 0 replies; 9+ messages in thread
From: Yong Liang @ 2020-01-13 9:41 UTC (permalink / raw)
To: Nicolas Boichat
Cc: Matthias Brugger, linux-arm Mailing List,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Mark Rutland, Devicetree List, lkml, wim, linux, linux-watchdog,
Jiaxin Yu (俞家鑫),
Sj Huang (黃信璋)
On Mon, 2020-01-13 at 14:27 +0800, Nicolas Boichat wrote:
> +Jiaxin +Sj Huang
>
> On Mon, Jan 13, 2020 at 12:44 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
> >
> > On Fri, Jan 10, 2020 at 6:09 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > > [snip]
> > > That's all a bit confusing, I thought we are fine to add the reset cells to
> > > infracfg as we have the resets defined in
> > > 64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
> >
> > You're right, we're fine. But at least in theory, we should still have
> > the binding documentation that I linked above.
> >
> > I will try to pick up all the required patches, split them across
> > 8183/2712 and resend as one series.
>
> Okay, summary of the patches, there are 2 series:
>
> https://patchwork.kernel.org/patch/11311237/
> [1.1] [v3,1/2] amr64: dts: modify mt8183.dtsi
> => Partially applied to Matthias' v5.5-next/dts64
> => Other part depend on [1.2], needs to be applied
> https://patchwork.kernel.org/patch/11311241/
> [1.2] [v3,2/2] dt-bindings: mt8183: Add watchdog dt-binding
> => Pending Guenter/Wim
>
> https://patchwork.kernel.org/cover/11326757/
> [2.0] [PATCH v11 0/3] ASoC: mt8183: fix audio playback slowly after playback
> [2.1] [PATCH v11 1/3] dt-bindings: mediatek: mt8183: Add #reset-cells
> => IMHO adding mt2712 compatible should be another patch
> => Depends on [1.2]
> => Tags should be all dropped
> [2.2] [PATCH v11 2/3] watchdog: mtk_wdt: mt8183: Add reset controller
> => Issues about tags
> [2.3] [PATCH v11 3/3] watchdog: mtk_wdt: mt2712: Add reset controller
> => Issues about tags
>
> Jiaxin/Yong Liang/Matthias: Please let me know, I'm happy to pick up
> the patches, clean them up and resend them, if you think that helps.
>
[1.2] [v3,2/2] dt-bindings: mt8183: Add watchdog dt-binding
-> It is no use, I will send 8183 in jiaxin's patch
We want to send jiaxin's patch prioritily. So you can merge
jiaxin's patch firstly.
>
> > > That's why I took this part from:
> > > https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
> > >
> > > Please let me know if I'm wrong and I'll drop it.
> > >
> > > Regards,
> > > Matthias
> > >
> > > >>> 2. Add watchdog device node
> > > >
> > > > Can we have a patch with just this change instead, since you're
> > > > sending the binding with it.
> > > >
> > > >>>
> > > >>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
> > > >>
> > > >> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
> > > >>
> > > >>> ---
> > > >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
> > > >>> 1 file changed, 8 insertions(+)
> > > >>> [snip]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-13 9:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191227141405.3396-1-yong.liang@mediatek.com>
[not found] ` <20191227141405.3396-2-yong.liang@mediatek.com>
2020-01-08 8:56 ` [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi Nicolas Boichat
2020-01-08 9:14 ` Nicolas Boichat
2020-01-09 3:59 ` Yong Liang
2020-01-10 10:09 ` Matthias Brugger
2020-01-13 4:44 ` Nicolas Boichat
2020-01-13 6:27 ` Nicolas Boichat
2020-01-13 9:41 ` Yong Liang
[not found] ` <20191227141405.3396-3-yong.liang@mediatek.com>
2020-01-08 8:57 ` [PATCH v3 2/2] dt-bindings: mt8183: Add watchdog dt-binding Nicolas Boichat
2020-01-08 10:59 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).