From: Guenter Roeck <linux@roeck-us.net>
To: Wan Jiabing <wanjiabing@vivo.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kael_w@yeah.net
Subject: Re: [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h
Date: Thu, 25 Mar 2021 07:36:57 -0700 [thread overview]
Message-ID: <48c7d893-532d-a62c-a300-09b3b9d6d746@roeck-us.net> (raw)
In-Reply-To: <20210325112916.865510-1-wanjiabing@vivo.com>
On 3/25/21 4:29 AM, Wan Jiabing wrote:
> linux/kernel.h has been included. Remove the duplicate.
> Reorder include files to be in alphabetic order.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changelog:
> v3:
> - Reorder include files to be in alphabetic order.
>
> v2:
> - Remove the duplicate which won't make worse.
> ---
> drivers/watchdog/dw_wdt.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63..cd578843277e 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -13,22 +13,21 @@
> */
>
> #include <linux/bitops.h>
> -#include <linux/limits.h>
> -#include <linux/kernel.h>
> #include <linux/clk.h>
> +#include <linux/debugfs.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> +#include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
> +#include <linux/limits.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> -#include <linux/interrupt.h>
> #include <linux/of.h>
> -#include <linux/pm.h>
> #include <linux/platform_device.h>
> +#include <linux/pm.h>
> #include <linux/reset.h>
> #include <linux/watchdog.h>
> -#include <linux/debugfs.h>
>
> #define WDOG_CONTROL_REG_OFFSET 0x00
> #define WDOG_CONTROL_REG_WDT_EN_MASK 0x01
>
prev parent reply other threads:[~2021-03-25 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 11:29 [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h Wan Jiabing
2021-03-25 14:36 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c7d893-532d-a62c-a300-09b3b9d6d746@roeck-us.net \
--to=linux@roeck-us.net \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wanjiabing@vivo.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).