From: Francesco Zanella <francesco.zanella@vimar.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: gpio-wdt: add "start-at-boot"
Date: Thu, 22 Apr 2021 18:28:16 +0200 [thread overview]
Message-ID: <49dc0cc4-c86b-3e47-f366-009406bc68a6@vimar.com> (raw)
In-Reply-To: <20210421163748.GA110463@roeck-us.net>
On 21/04/21 18:37, Guenter Roeck wrote:
> On Wed, Apr 21, 2021 at 06:26:20PM +0200, Francesco Zanella wrote:
>> Documentation for new device tree property "start-at-boot".
>>
>> Signed-off-by: Francesco Zanella <francesco.zanella@vimar.com>
>> ---
>> Documentation/devicetree/bindings/watchdog/gpio-wdt.txt | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>> index 198794963786..cdaf7f0602e8 100644
>> --- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>> @@ -17,6 +17,13 @@ Optional Properties:
>> - always-running: If the watchdog timer cannot be disabled, add this flag to
>> have the driver keep toggling the signal without a client. It will only cease
>> to toggle the signal when the device is open and the timeout elapsed.
>> +- start-at-boot: Start pinging hw watchdog at probe, in order to take advantage
>> + of kernel configs:
>> + - WATCHDOG_HANDLE_BOOT_ENABLED: Avoid possible reboot if hw watchdog was been
>> + enabled before the kernel (by uboot for example) and userspace doesn't take
>> + control of /dev/watchdog in time;
>> + - WATCHDOG_OPEN_TIMEOUT: Reboot if userspace doesn't take control of
>> + /dev/watchdog within the timeout.
>
> You are not supposed to refer to Linux kernel details in devicetree
> bindings documents.
>
> Guenter
>
>>
>> Example:
>> watchdog: watchdog {
>> --
>> 2.17.1
>>
OK, I'm sorry. I will resend the patch series without kernel configs
references in documents.
Francesco
next prev parent reply other threads:[~2021-04-22 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 16:26 [PATCH 0/2] GPIO WDT "start-at-boot" property Francesco Zanella
2021-04-21 16:26 ` [PATCH 1/2] dt-bindings: watchdog: gpio-wdt: add "start-at-boot" Francesco Zanella
2021-04-21 16:37 ` Guenter Roeck
2021-04-22 16:28 ` Francesco Zanella [this message]
2021-04-21 16:26 ` [PATCH 2/2] watchdog: gpio_wdt: add "start-at-boot" feature Francesco Zanella
2021-04-21 16:42 ` Guenter Roeck
2021-04-22 16:28 ` Francesco Zanella
2021-04-22 18:05 ` Guenter Roeck
2021-04-23 9:47 ` Francesco Zanella
2021-04-23 11:36 ` Rasmus Villemoes
2021-04-23 14:24 ` Francesco Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49dc0cc4-c86b-3e47-f366-009406bc68a6@vimar.com \
--to=francesco.zanella@vimar.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).