linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] watchdog: sbsa: drop unneeded MODULE_ALIAS
@ 2021-09-17  9:20 Krzysztof Kozlowski
  2021-09-17 13:47 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-17  9:20 UTC (permalink / raw)
  To: linux-kernel
  Cc: Krzysztof Kozlowski, Wim Van Sebroeck, Guenter Roeck, linux-watchdog

The MODULE_DEVICE_TABLE already creates proper alias for platform
driver.  Having another MODULE_ALIAS causes the alias to be duplicated.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/watchdog/sbsa_gwdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
index ee9ff38929eb..87b496405871 100644
--- a/drivers/watchdog/sbsa_gwdt.c
+++ b/drivers/watchdog/sbsa_gwdt.c
@@ -411,4 +411,3 @@ MODULE_AUTHOR("Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>");
 MODULE_AUTHOR("Al Stone <al.stone@linaro.org>");
 MODULE_AUTHOR("Timur Tabi <timur@codeaurora.org>");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:" DRV_NAME);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: sbsa: drop unneeded MODULE_ALIAS
  2021-09-17  9:20 [PATCH] watchdog: sbsa: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
@ 2021-09-17 13:47 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-09-17 13:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski, linux-kernel; +Cc: Wim Van Sebroeck, linux-watchdog

On 9/17/21 2:20 AM, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver.  Having another MODULE_ALIAS causes the alias to be duplicated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/sbsa_gwdt.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index ee9ff38929eb..87b496405871 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -411,4 +411,3 @@ MODULE_AUTHOR("Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>");
>   MODULE_AUTHOR("Al Stone <al.stone@linaro.org>");
>   MODULE_AUTHOR("Timur Tabi <timur@codeaurora.org>");
>   MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform:" DRV_NAME);
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-17 13:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17  9:20 [PATCH] watchdog: sbsa: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-17 13:47 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).