From: Guenter Roeck <linux@roeck-us.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Paul Cercueil <paul@crapouillou.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: jz4740: Fix unused variable warning in jz4740_wdt_probe
Date: Tue, 6 Aug 2019 04:04:07 -0700 [thread overview]
Message-ID: <9c93e60f-4122-282c-db28-0b6dd64af3d5@roeck-us.net> (raw)
In-Reply-To: <20190806073953.GA13685@embeddedor>
On 8/6/19 12:39 AM, Gustavo A. R. Silva wrote:
> Fix the following warning (Building: ci20_defconfig mips):
>
> drivers/watchdog/jz4740_wdt.c: In function ‘jz4740_wdt_probe’:
> drivers/watchdog/jz4740_wdt.c:165:6: warning: unused variable ‘ret’ [-Wunused-variable]
> int ret;
> ^~~
> Fixes: 9ee644c9326c ("watchdog: jz4740_wdt: drop warning after registering device")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/jz4740_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> index d4a90916dd38..c6052ae54f32 100644
> --- a/drivers/watchdog/jz4740_wdt.c
> +++ b/drivers/watchdog/jz4740_wdt.c
> @@ -162,7 +162,6 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct jz4740_wdt_drvdata *drvdata;
> struct watchdog_device *jz4740_wdt;
> - int ret;
>
> drvdata = devm_kzalloc(dev, sizeof(struct jz4740_wdt_drvdata),
> GFP_KERNEL);
>
prev parent reply other threads:[~2019-08-06 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 7:39 [PATCH] watchdog: jz4740: Fix unused variable warning in jz4740_wdt_probe Gustavo A. R. Silva
2019-08-06 11:04 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c93e60f-4122-282c-db28-0b6dd64af3d5@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).