Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] watchdog: jz4740: Fix unused variable warning in jz4740_wdt_probe
@ 2019-08-06  7:39 Gustavo A. R. Silva
  2019-08-06 11:04 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-06  7:39 UTC (permalink / raw)
  To: Paul Cercueil, Wim Van Sebroeck, Guenter Roeck, Wolfram Sang
  Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva

Fix the following warning (Building: ci20_defconfig mips):

drivers/watchdog/jz4740_wdt.c: In function ‘jz4740_wdt_probe’:
drivers/watchdog/jz4740_wdt.c:165:6: warning: unused variable ‘ret’ [-Wunused-variable]
  int ret;
      ^~~
Fixes: 9ee644c9326c ("watchdog: jz4740_wdt: drop warning after registering device")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/watchdog/jz4740_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
index d4a90916dd38..c6052ae54f32 100644
--- a/drivers/watchdog/jz4740_wdt.c
+++ b/drivers/watchdog/jz4740_wdt.c
@@ -162,7 +162,6 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct jz4740_wdt_drvdata *drvdata;
 	struct watchdog_device *jz4740_wdt;
-	int ret;
 
 	drvdata = devm_kzalloc(dev, sizeof(struct jz4740_wdt_drvdata),
 			       GFP_KERNEL);
-- 
2.22.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: jz4740: Fix unused variable warning in jz4740_wdt_probe
  2019-08-06  7:39 [PATCH] watchdog: jz4740: Fix unused variable warning in jz4740_wdt_probe Gustavo A. R. Silva
@ 2019-08-06 11:04 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-08-06 11:04 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Paul Cercueil, Wim Van Sebroeck, Wolfram Sang
  Cc: linux-watchdog, linux-kernel

On 8/6/19 12:39 AM, Gustavo A. R. Silva wrote:
> Fix the following warning (Building: ci20_defconfig mips):
> 
> drivers/watchdog/jz4740_wdt.c: In function ‘jz4740_wdt_probe’:
> drivers/watchdog/jz4740_wdt.c:165:6: warning: unused variable ‘ret’ [-Wunused-variable]
>    int ret;
>        ^~~
> Fixes: 9ee644c9326c ("watchdog: jz4740_wdt: drop warning after registering device")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/jz4740_wdt.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> index d4a90916dd38..c6052ae54f32 100644
> --- a/drivers/watchdog/jz4740_wdt.c
> +++ b/drivers/watchdog/jz4740_wdt.c
> @@ -162,7 +162,6 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
>   	struct device *dev = &pdev->dev;
>   	struct jz4740_wdt_drvdata *drvdata;
>   	struct watchdog_device *jz4740_wdt;
> -	int ret;
>   
>   	drvdata = devm_kzalloc(dev, sizeof(struct jz4740_wdt_drvdata),
>   			       GFP_KERNEL);
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06  7:39 [PATCH] watchdog: jz4740: Fix unused variable warning in jz4740_wdt_probe Gustavo A. R. Silva
2019-08-06 11:04 ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org linux-watchdog@archiver.kernel.org
	public-inbox-index linux-watchdog


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/ public-inbox