From: Rob Herring <robh@kernel.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: Sven Peter <sven@svenpeter.dev>,
devicetree@vger.kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net, marcan@marcan.st, alyssa@rosenzweig.io,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add Apple Watchdog
Date: Mon, 29 Nov 2021 15:23:48 -0600 [thread overview]
Message-ID: <YaVE5IL7oO3Q4u5h@robh.at.kernel.org> (raw)
In-Reply-To: <d3cad4a2f2f05eef@bloch.sibelius.xs4all.nl>
On Sun, Nov 14, 2021 at 12:58:20PM +0100, Mark Kettenis wrote:
> > Date: Sun, 14 Nov 2021 12:40:48 +0100
> > From: "Sven Peter" <sven@svenpeter.dev>
> >
> > On Sat, Nov 13, 2021, at 22:07, Mark Kettenis wrote:
> > >> From: Sven Peter <sven@svenpeter.dev>
> > >> Date: Sat, 13 Nov 2021 10:47:31 +0100
> > >>
> > >> Apple SoCs come with a simple embedded watchdog. This watchdog is also
> > >> required in order to reset the SoC.
> > >>
> > >> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> > >> ---
> > >> .../bindings/watchdog/apple,wdt.yaml | 52 +++++++++++++++++++
> > >> MAINTAINERS | 1 +
> > >> 2 files changed, 53 insertions(+)
> > >> create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> > >> new file mode 100644
> > >> index 000000000000..e58c56a6fdf6
> > >> --- /dev/null
> > >> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> > >> @@ -0,0 +1,52 @@
> > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > >> +%YAML 1.2
> > >> +---
> > >> +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml#
> > >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > >> +
> > >> +title: Apple SoC Watchdog
> > >> +
> > >> +allOf:
> > >> + - $ref: "watchdog.yaml#"
> > >
> > > I believew this should be:
> > >
> > > - $ref: /schemas/watchdog/watchdog.yaml#
> > >
> > > with that fixed:
> > >
> > > Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> > >
> >
> > Thanks for the review!
> > Almost all the other YAML watchdog bindings just use '$ref: "watchdog.yaml#"'.
> > Only arm,sp805.yaml uses '$ref: /schemas/watchdog/watchdog.yaml#'.
>
> Hmm, maybe it is ok since the file can be found in the same directory.
> Guess it is up to robh then. Feel free to keep my Reviewed-by
> regardless.
Either way is fine. It's just ../ paths I want to avoid.
Rob
next prev parent reply other threads:[~2021-11-29 21:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 9:47 [PATCH 1/2] dt-bindings: watchdog: Add Apple Watchdog Sven Peter
2021-11-13 9:47 ` [PATCH 2/2] watchdog: Add Apple SoC watchdog driver Sven Peter
2021-11-13 11:14 ` Janne Grunau
2021-11-13 11:19 ` Sven Peter
2021-11-13 15:24 ` Alyssa Rosenzweig
2021-11-14 11:37 ` Sven Peter
2021-11-14 13:18 ` Alyssa Rosenzweig
2021-12-02 5:14 ` Hector Martin
2021-12-02 11:05 ` Sven Peter
2021-11-14 12:42 ` Guenter Roeck
2021-11-14 13:25 ` Sven Peter
2021-11-13 21:07 ` [PATCH 1/2] dt-bindings: watchdog: Add Apple Watchdog Mark Kettenis
2021-11-14 11:40 ` Sven Peter
2021-11-14 11:58 ` Mark Kettenis
2021-11-29 21:23 ` Rob Herring [this message]
2021-11-29 21:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaVE5IL7oO3Q4u5h@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcan@marcan.st \
--cc=mark.kettenis@xs4all.nl \
--cc=sven@svenpeter.dev \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).