From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Sven Peter <sven@svenpeter.dev>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
sven@svenpeter.dev, wim@linux-watchdog.org, linux@roeck-us.net,
marcan@marcan.st, alyssa@rosenzweig.io,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add Apple Watchdog
Date: Sat, 13 Nov 2021 22:07:42 +0100 (CET) [thread overview]
Message-ID: <d3cad37524f7debf@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211113094732.73889-1-sven@svenpeter.dev> (message from Sven Peter on Sat, 13 Nov 2021 10:47:31 +0100)
> From: Sven Peter <sven@svenpeter.dev>
> Date: Sat, 13 Nov 2021 10:47:31 +0100
>
> Apple SoCs come with a simple embedded watchdog. This watchdog is also
> required in order to reset the SoC.
>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
> .../bindings/watchdog/apple,wdt.yaml | 52 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> new file mode 100644
> index 000000000000..e58c56a6fdf6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple SoC Watchdog
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
I believew this should be:
- $ref: /schemas/watchdog/watchdog.yaml#
with that fixed:
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> +
> +maintainers:
> + - Sven Peter <sven@svenpeter.dev>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,t8103-wdt
> + - apple,t6000-wdt
> + - const: apple,wdt
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/apple-aic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + wdt: watchdog@50000000 {
> + compatible = "apple,t8103-wdt", "apple,wdt";
> + reg = <0x50000000 0x4000>;
> + clocks = <&clk>;
> + interrupts = <AIC_IRQ 123 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5b7a13f706fa..ba480837724d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1749,6 +1749,7 @@ F: Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
> F: Documentation/devicetree/bindings/pci/apple,pcie.yaml
> F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
> +F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> F: arch/arm64/boot/dts/apple/
> F: drivers/i2c/busses/i2c-pasemi-core.c
> F: drivers/i2c/busses/i2c-pasemi-platform.c
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-11-13 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 9:47 [PATCH 1/2] dt-bindings: watchdog: Add Apple Watchdog Sven Peter
2021-11-13 9:47 ` [PATCH 2/2] watchdog: Add Apple SoC watchdog driver Sven Peter
2021-11-13 11:14 ` Janne Grunau
2021-11-13 11:19 ` Sven Peter
2021-11-13 15:24 ` Alyssa Rosenzweig
2021-11-14 11:37 ` Sven Peter
2021-11-14 13:18 ` Alyssa Rosenzweig
2021-12-02 5:14 ` Hector Martin
2021-12-02 11:05 ` Sven Peter
2021-11-14 12:42 ` Guenter Roeck
2021-11-14 13:25 ` Sven Peter
2021-11-13 21:07 ` Mark Kettenis [this message]
2021-11-14 11:40 ` [PATCH 1/2] dt-bindings: watchdog: Add Apple Watchdog Sven Peter
2021-11-14 11:58 ` Mark Kettenis
2021-11-29 21:23 ` Rob Herring
2021-11-29 21:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3cad37524f7debf@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).