* [PATCH 2/4] watchdog: twl4030_wdt: add missing of.h include
2022-09-27 5:22 [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include Dmitry Torokhov
@ 2022-09-27 5:22 ` Dmitry Torokhov
2022-09-27 10:55 ` Guenter Roeck
2022-09-27 12:23 ` Andy Shevchenko
2022-09-27 5:22 ` [PATCH 3/4] mfd: twl4030-irq: add missing device.h include Dmitry Torokhov
` (3 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Dmitry Torokhov @ 2022-09-27 5:22 UTC (permalink / raw)
To: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck
Cc: Lars-Peter Clausen, Tony Lindgren, Andy Shevchenko, linux-iio,
linux-watchdog, linux-input, linux-kernel
The driver is using of_device_id and therefore needs to include
of.h header. We used to get this definition indirectly via inclusion
of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
from unnecessary includes.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/watchdog/twl4030_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
index 355e428c0b99..e715ac1369a0 100644
--- a/drivers/watchdog/twl4030_wdt.c
+++ b/drivers/watchdog/twl4030_wdt.c
@@ -9,6 +9,7 @@
#include <linux/types.h>
#include <linux/slab.h>
#include <linux/kernel.h>
+#include <linux/of.h>
#include <linux/watchdog.h>
#include <linux/platform_device.h>
#include <linux/mfd/twl.h>
--
2.38.0.rc1.362.ged0d419d3c-goog
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/4] watchdog: twl4030_wdt: add missing of.h include
2022-09-27 5:22 ` [PATCH 2/4] watchdog: twl4030_wdt: " Dmitry Torokhov
@ 2022-09-27 10:55 ` Guenter Roeck
2022-09-27 12:23 ` Andy Shevchenko
1 sibling, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2022-09-27 10:55 UTC (permalink / raw)
To: Dmitry Torokhov, Jonathan Cameron, Lee Jones, Wim Van Sebroeck
Cc: Lars-Peter Clausen, Tony Lindgren, Andy Shevchenko, linux-iio,
linux-watchdog, linux-input, linux-kernel
On 9/26/22 22:22, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> of.h header. We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/twl4030_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
> index 355e428c0b99..e715ac1369a0 100644
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -9,6 +9,7 @@
> #include <linux/types.h>
> #include <linux/slab.h>
> #include <linux/kernel.h>
> +#include <linux/of.h>
> #include <linux/watchdog.h>
> #include <linux/platform_device.h>
> #include <linux/mfd/twl.h>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] watchdog: twl4030_wdt: add missing of.h include
2022-09-27 5:22 ` [PATCH 2/4] watchdog: twl4030_wdt: " Dmitry Torokhov
2022-09-27 10:55 ` Guenter Roeck
@ 2022-09-27 12:23 ` Andy Shevchenko
1 sibling, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2022-09-27 12:23 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck,
Lars-Peter Clausen, Tony Lindgren, linux-iio, linux-watchdog,
linux-input, linux-kernel
On Mon, Sep 26, 2022 at 10:22:14PM -0700, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> of.h header.
This is incorrect. For of_device_id the mod_devicetable.h should be used.
> We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/4] mfd: twl4030-irq: add missing device.h include
2022-09-27 5:22 [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include Dmitry Torokhov
2022-09-27 5:22 ` [PATCH 2/4] watchdog: twl4030_wdt: " Dmitry Torokhov
@ 2022-09-27 5:22 ` Dmitry Torokhov
2022-09-27 12:25 ` Andy Shevchenko
2022-09-27 5:22 ` [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include Dmitry Torokhov
` (2 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Dmitry Torokhov @ 2022-09-27 5:22 UTC (permalink / raw)
To: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck
Cc: Lars-Peter Clausen, Tony Lindgren, Andy Shevchenko, linux-iio,
linux-watchdog, linux-input, linux-kernel
The driver is using "struct device" and therefore needs to include
device.h header. We used to get this definition indirectly via inclusion
of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
from unnecessary includes.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/mfd/twl4030-irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 4f576f0160a9..87496c1cb8bc 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -14,6 +14,7 @@
* by syed khasim <x0khasim@ti.com>
*/
+#include <linux/device.h>
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
--
2.38.0.rc1.362.ged0d419d3c-goog
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 3/4] mfd: twl4030-irq: add missing device.h include
2022-09-27 5:22 ` [PATCH 3/4] mfd: twl4030-irq: add missing device.h include Dmitry Torokhov
@ 2022-09-27 12:25 ` Andy Shevchenko
0 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2022-09-27 12:25 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck,
Lars-Peter Clausen, Tony Lindgren, linux-iio, linux-watchdog,
linux-input, linux-kernel
On Mon, Sep 26, 2022 at 10:22:15PM -0700, Dmitry Torokhov wrote:
> The driver is using "struct device" and therefore needs to include
> device.h header. We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 4f576f0160a9..87496c1cb8bc 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -14,6 +14,7 @@
> * by syed khasim <x0khasim@ti.com>
> */
>
> +#include <linux/device.h>
> #include <linux/export.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include
2022-09-27 5:22 [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include Dmitry Torokhov
2022-09-27 5:22 ` [PATCH 2/4] watchdog: twl4030_wdt: " Dmitry Torokhov
2022-09-27 5:22 ` [PATCH 3/4] mfd: twl4030-irq: add missing device.h include Dmitry Torokhov
@ 2022-09-27 5:22 ` Dmitry Torokhov
2022-09-27 12:24 ` Andy Shevchenko
2022-09-27 12:24 ` [PATCH 1/4] Input: twl4030-pwrbutton - " Andy Shevchenko
2022-09-28 6:48 ` Mattijs Korpershoek
4 siblings, 1 reply; 12+ messages in thread
From: Dmitry Torokhov @ 2022-09-27 5:22 UTC (permalink / raw)
To: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck
Cc: Lars-Peter Clausen, Tony Lindgren, Andy Shevchenko, linux-iio,
linux-watchdog, linux-input, linux-kernel
The driver is using of_device_id and therefore needs to include
of.h header. We used to get this definition indirectly via inclusion
of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
from unnecessary includes.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/iio/adc/twl4030-madc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
index f8f8aea15612..c279c4f2c9b7 100644
--- a/drivers/iio/adc/twl4030-madc.c
+++ b/drivers/iio/adc/twl4030-madc.c
@@ -30,6 +30,7 @@
#include <linux/types.h>
#include <linux/gfp.h>
#include <linux/err.h>
+#include <linux/of.h>
#include <linux/regulator/consumer.h>
#include <linux/iio/iio.h>
--
2.38.0.rc1.362.ged0d419d3c-goog
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include
2022-09-27 5:22 ` [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include Dmitry Torokhov
@ 2022-09-27 12:24 ` Andy Shevchenko
2022-09-27 15:36 ` Dmitry Torokhov
0 siblings, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2022-09-27 12:24 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck,
Lars-Peter Clausen, Tony Lindgren, linux-iio, linux-watchdog,
linux-input, linux-kernel
On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> of.h header.
As per patch 2 comment, mod_devicetable.h is needed for that.
> We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include
2022-09-27 12:24 ` Andy Shevchenko
@ 2022-09-27 15:36 ` Dmitry Torokhov
2022-09-27 15:54 ` Andy Shevchenko
0 siblings, 1 reply; 12+ messages in thread
From: Dmitry Torokhov @ 2022-09-27 15:36 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck,
Lars-Peter Clausen, Tony Lindgren, linux-iio, linux-watchdog,
linux-input, linux-kernel
On Tue, Sep 27, 2022 at 03:24:25PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote:
> > The driver is using of_device_id and therefore needs to include
> > of.h header.
>
> As per patch 2 comment, mod_devicetable.h is needed for that.
It also uses of_match_ptr(), so of.h is the one that is needed. I'll
adjust the patch description.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include
2022-09-27 15:36 ` Dmitry Torokhov
@ 2022-09-27 15:54 ` Andy Shevchenko
0 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2022-09-27 15:54 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck,
Lars-Peter Clausen, Tony Lindgren, linux-iio, linux-watchdog,
linux-input, linux-kernel
On Tue, Sep 27, 2022 at 08:36:22AM -0700, Dmitry Torokhov wrote:
> On Tue, Sep 27, 2022 at 03:24:25PM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote:
> > > The driver is using of_device_id and therefore needs to include
> > > of.h header.
> >
> > As per patch 2 comment, mod_devicetable.h is needed for that.
>
> It also uses of_match_ptr(), so of.h is the one that is needed. I'll
> adjust the patch description.
Thank you! In such case feel free to add my tag.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include
2022-09-27 5:22 [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include Dmitry Torokhov
` (2 preceding siblings ...)
2022-09-27 5:22 ` [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include Dmitry Torokhov
@ 2022-09-27 12:24 ` Andy Shevchenko
2022-09-28 6:48 ` Mattijs Korpershoek
4 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2022-09-27 12:24 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jonathan Cameron, Lee Jones, Wim Van Sebroeck, Guenter Roeck,
Lars-Peter Clausen, Tony Lindgren, linux-iio, linux-watchdog,
linux-input, linux-kernel
On Mon, Sep 26, 2022 at 10:22:13PM -0700, Dmitry Torokhov wrote:
> The driver is using of_match_ptr() and therefore needs to include
> of.h header.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/misc/twl4030-pwrbutton.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index b307cca17022..e3ee0638ffba 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -26,6 +26,7 @@
> #include <linux/errno.h>
> #include <linux/input.h>
> #include <linux/interrupt.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/mfd/twl.h>
>
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include
2022-09-27 5:22 [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include Dmitry Torokhov
` (3 preceding siblings ...)
2022-09-27 12:24 ` [PATCH 1/4] Input: twl4030-pwrbutton - " Andy Shevchenko
@ 2022-09-28 6:48 ` Mattijs Korpershoek
4 siblings, 0 replies; 12+ messages in thread
From: Mattijs Korpershoek @ 2022-09-28 6:48 UTC (permalink / raw)
To: Dmitry Torokhov, Jonathan Cameron, Lee Jones, Wim Van Sebroeck,
Guenter Roeck
Cc: Lars-Peter Clausen, Tony Lindgren, Andy Shevchenko, linux-iio,
linux-watchdog, linux-input, linux-kernel
On Mon, Sep 26, 2022 at 22:22, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> The driver is using of_match_ptr() and therefore needs to include
> of.h header.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/input/misc/twl4030-pwrbutton.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index b307cca17022..e3ee0638ffba 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -26,6 +26,7 @@
> #include <linux/errno.h>
> #include <linux/input.h>
> #include <linux/interrupt.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/mfd/twl.h>
>
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
^ permalink raw reply [flat|nested] 12+ messages in thread