From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>, Nguyen An Hoan <na-hoan@jinso.co.jp>
Cc: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
wsa+renesas@sang-engineering.com,
kuninori.morimoto.gx@renesas.com,
yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
cv-dong@jinso.co.jp
Subject: Re: [PATCH] watchdog: renesas_wdt: Use 'dev' instead of dereferencing it repeatedly
Date: Mon, 27 May 2019 09:22:05 -0700 [thread overview]
Message-ID: <a0919587-7a42-b998-ae05-9d8e4ddf6e4c@roeck-us.net> (raw)
In-Reply-To: <20190523110649.GB3979@kunai>
On 5/23/19 4:06 AM, Wolfram Sang wrote:
> Hi,
>
> On Thu, May 23, 2019 at 06:29:38PM +0900, Nguyen An Hoan wrote:
>> From: Hoan Nguyen An <na-hoan@jinso.co.jp>
>>
>> Add helper variable dev = &pdev->dev
>>
>> Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
>
> Hmm, I leave the decision to Guenter. Dunno if there is a subsystem
> preference. I personally don't think it adds value but I am not against
> it.
>
I like it because it makes the code easier to read.
Guenter
next prev parent reply other threads:[~2019-05-27 16:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:29 [PATCH] watchdog: renesas_wdt: Fix interrupt enable for timer Nguyen An Hoan
2019-05-23 9:29 ` [PATCH] watchdog: renesas_wdt: Use 'dev' instead of dereferencing it repeatedly Nguyen An Hoan
2019-05-23 11:06 ` Wolfram Sang
2019-05-27 16:22 ` Guenter Roeck [this message]
2019-05-28 7:38 ` Geert Uytterhoeven
2019-06-07 17:31 ` Guenter Roeck
2019-06-13 9:28 ` Simon Horman
2019-05-23 11:04 ` [PATCH] watchdog: renesas_wdt: Fix interrupt enable for timer Wolfram Sang
2019-05-23 11:26 ` Geert Uytterhoeven
2019-05-24 1:13 ` "グェン・アン・ホァン"
2019-05-24 2:01 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0919587-7a42-b998-ae05-9d8e4ddf6e4c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cv-dong@jinso.co.jp \
--cc=geert+renesas@glider.be \
--cc=h-inayoshi@jinso.co.jp \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=na-hoan@jinso.co.jp \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).