* [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h
@ 2021-05-13 2:05 Jiapeng Chong
2021-05-13 3:15 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-13 2:05 UTC (permalink / raw)
To: wim; +Cc: linux, p.zabel, linux-watchdog, linux-kernel, Jiapeng Chong
Clean up the following includecheck warning:
./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/watchdog/dw_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index 32d0e17..b1642e2 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c
@@ -19,7 +19,6 @@
#include <linux/delay.h>
#include <linux/err.h>
#include <linux/io.h>
-#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/interrupt.h>
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h
2021-05-13 2:05 [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h Jiapeng Chong
@ 2021-05-13 3:15 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-05-13 3:15 UTC (permalink / raw)
To: Jiapeng Chong, wim; +Cc: p.zabel, linux-watchdog, linux-kernel
On 5/12/21 7:05 PM, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
>
> ./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/watchdog/dw_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e17..b1642e2 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/interrupt.h>
>
When making such changes, please use the opportunity to reorder include files
in alphabetic order to help ensure that duplicate includes don't happen again.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-13 3:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 2:05 [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h Jiapeng Chong
2021-05-13 3:15 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).