From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: [RESEND PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API
Date: Tue, 13 Apr 2021 12:46:43 +0200 [thread overview]
Message-ID: <cover.dc9133eee56aa67653455928e4de2162e344ce4d.1618310618.git-series.a.fatoum@pengutronix.de> (raw)
This series migrates the driver to the new kernel watchdog API and
then to the driver model.
Main feedback from Guenther on v2 was that I need to split it up to
enable review. I have done so by removing the extra refactoring for
now and focused on the functional changes described above. The diff
is now much better readable.
I tested it on a f81866.
v3 -> RESEND:
https://lore.kernel.org/linux-watchdog/cover.dedd9f1159389b0a438076ef5e5a46aded186463.1612457906.git-series.a.fatoum@pengutronix.de/#t
Didn't generate any feedback over 2 months. Resending for exposure.
v2 -> v3:
https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@pengutronix.de/
- factored out identifier renaming again for easier review
- reordered commits
- removed refactoring that can go in later. Focusing now on kernel watchdog
API and platform device/driver migration
- removed platform_device_id and changed code to match by name
v1 -> v2:
https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@pengutronix.de/
- reworked to platform device/driver pair (Guenther)
- squashed identifier renaming into the patches that touch
the respective lines anyway
- fixed checkpatch.pl nitpicks (Guenther)
- fixed locally used variable declared without static (0-day)
- fixed unneded line break due to old line limit (Guenther)
- renamed struct fintek_wdog_data to struct fintek_wdt
Ahmad Fatoum (3):
watchdog: f71808e_wdt: rename variant-independent identifiers appropriately
watchdog: f71808e_wdt: migrate to new kernel watchdog API
watchdog: f71808e_wdt: refactor to platform device/driver pair
drivers/watchdog/Kconfig | 1 +-
drivers/watchdog/f71808e_wdt.c | 450 +++++++---------------------------
2 files changed, 100 insertions(+), 351 deletions(-)
base-commit: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac
--
git-series 0.9.1
next reply other threads:[~2021-04-13 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 10:46 Ahmad Fatoum [this message]
2021-04-13 10:46 ` [RESEND PATCH v3 1/3] watchdog: f71808e_wdt: rename variant-independent identifiers appropriately Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new kernel watchdog API Ahmad Fatoum
2021-05-03 14:31 ` Guenter Roeck
2021-05-03 14:39 ` Ahmad Fatoum
2021-05-03 15:28 ` Guenter Roeck
2021-05-03 18:33 ` Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 3/3] watchdog: f71808e_wdt: refactor to platform device/driver pair Ahmad Fatoum
2021-05-03 13:09 ` [RESEND PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API Marc Kleine-Budde
2021-05-03 13:33 ` Guenter Roeck
2021-05-03 13:49 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.dc9133eee56aa67653455928e4de2162e344ce4d.1618310618.git-series.a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).