linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: linux-input@vger.kernel.org
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	dmitry.torokhov@gmail.com, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 1/2] input: Add KEY_RFKILL_ALL
Date: Sat,  1 Aug 2009 19:54:18 +0100	[thread overview]
Message-ID: <1249152859-14769-1-git-send-email-mjg@redhat.com> (raw)

Most laptops have keys that are intended to toggle all device state, not
just wifi. These are currently generally mapped to KEY_WLAN. As a result,
rfkill will only kill or enable wifi in response to the key press. This
confuses users and can make it difficult for them to enable bluetooth
and wwan devices.

This patch adds a new keycode, KEY_RFKILL_ALL. It indicates that the
system should toggle the state of all rfkillable devices.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 include/linux/input.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/input.h b/include/linux/input.h
index 8b3bc3e..0eff8ff 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -595,6 +595,8 @@ struct input_absinfo {
 #define KEY_NUMERIC_STAR	0x20a
 #define KEY_NUMERIC_POUND	0x20b
 
+#define KEY_RFKILL_ALL		0x20c
+
 /* We avoid low common keys in module aliases so they don't get huge. */
 #define KEY_MIN_INTERESTING	KEY_MUTE
 #define KEY_MAX			0x2ff
-- 
1.6.2.5


             reply	other threads:[~2009-08-01 18:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01 18:54 Matthew Garrett [this message]
2009-08-01 18:54 ` [PATCH 2/2] rfkill: Add support for KEY_RFKILL_ALL Matthew Garrett
2009-08-01 20:25   ` Bastien Nocera
2009-08-01 20:41     ` Marcel Holtmann
2009-08-01 20:38 ` [PATCH 1/2] input: Add KEY_RFKILL_ALL Marcel Holtmann
2009-08-01 20:45   ` Matthew Garrett
2009-08-01 20:52     ` Marcel Holtmann
2009-08-01 20:54       ` Matthew Garrett
2009-08-01 21:48         ` Marcel Holtmann
2009-08-01 21:51           ` Matthew Garrett
2009-08-01 22:11             ` Marcel Holtmann
2009-08-01 22:25               ` Matthew Garrett
2009-08-02  7:55                 ` Johannes Berg
2009-08-02  1:05 ` Henrique de Moraes Holschuh
2009-08-02  1:15   ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249152859-14769-1-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).