linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-input@vger.kernel.org, johannes@sipsolutions.net,
	linux-wireless@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 1/2] input: Add KEY_RFKILL_ALL
Date: Sat, 01 Aug 2009 15:11:25 -0700	[thread overview]
Message-ID: <1249164685.3491.28.camel@localhost.localdomain> (raw)
In-Reply-To: <20090801215130.GA24201@srcf.ucam.org>

Hi Matthew,

> > why is it confusing? I don't understanding your argument here. I think
> > the KEY_RFKILL_ALL is confusing is the user policy then only kills WiFi
> > devices or toggles between various on/off combinations.
> 
> Having it be KEY_RFKILL implies that KEY_WLAN and similar aren't related 
> to rfkill. KEY_RFKILL_ALL implies that the key invokes policy on all 
> rfkill devices, which is the aim here.

and that is what it should NOT imply. The policy if it applies to all
internal devices, all devices in general or just WiFi or Bluetooth for
example is up to the user.

We are NOT going to have any kind of RFKILL policy in the kernel in the
future. We will remove rfkill-input once we have a proper userspace
solution (aka rfkilld or similar).

Regards

Marcel



  reply	other threads:[~2009-08-01 22:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01 18:54 [PATCH 1/2] input: Add KEY_RFKILL_ALL Matthew Garrett
2009-08-01 18:54 ` [PATCH 2/2] rfkill: Add support for KEY_RFKILL_ALL Matthew Garrett
2009-08-01 20:25   ` Bastien Nocera
2009-08-01 20:41     ` Marcel Holtmann
2009-08-01 20:38 ` [PATCH 1/2] input: Add KEY_RFKILL_ALL Marcel Holtmann
2009-08-01 20:45   ` Matthew Garrett
2009-08-01 20:52     ` Marcel Holtmann
2009-08-01 20:54       ` Matthew Garrett
2009-08-01 21:48         ` Marcel Holtmann
2009-08-01 21:51           ` Matthew Garrett
2009-08-01 22:11             ` Marcel Holtmann [this message]
2009-08-01 22:25               ` Matthew Garrett
2009-08-02  7:55                 ` Johannes Berg
2009-08-02  1:05 ` Henrique de Moraes Holschuh
2009-08-02  1:15   ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249164685.3491.28.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).