From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-input@vger.kernel.org, johannes@sipsolutions.net,
linux-wireless@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 1/2] input: Add KEY_RFKILL_ALL
Date: Sat, 1 Aug 2009 22:51:30 +0100 [thread overview]
Message-ID: <20090801215130.GA24201@srcf.ucam.org> (raw)
In-Reply-To: <1249163327.3491.24.camel@localhost.localdomain>
On Sat, Aug 01, 2009 at 02:48:47PM -0700, Marcel Holtmann wrote:
> why is it confusing? I don't understanding your argument here. I think
> the KEY_RFKILL_ALL is confusing is the user policy then only kills WiFi
> devices or toggles between various on/off combinations.
Having it be KEY_RFKILL implies that KEY_WLAN and similar aren't related
to rfkill. KEY_RFKILL_ALL implies that the key invokes policy on all
rfkill devices, which is the aim here.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-08-01 21:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 18:54 [PATCH 1/2] input: Add KEY_RFKILL_ALL Matthew Garrett
2009-08-01 18:54 ` [PATCH 2/2] rfkill: Add support for KEY_RFKILL_ALL Matthew Garrett
2009-08-01 20:25 ` Bastien Nocera
2009-08-01 20:41 ` Marcel Holtmann
2009-08-01 20:38 ` [PATCH 1/2] input: Add KEY_RFKILL_ALL Marcel Holtmann
2009-08-01 20:45 ` Matthew Garrett
2009-08-01 20:52 ` Marcel Holtmann
2009-08-01 20:54 ` Matthew Garrett
2009-08-01 21:48 ` Marcel Holtmann
2009-08-01 21:51 ` Matthew Garrett [this message]
2009-08-01 22:11 ` Marcel Holtmann
2009-08-01 22:25 ` Matthew Garrett
2009-08-02 7:55 ` Johannes Berg
2009-08-02 1:05 ` Henrique de Moraes Holschuh
2009-08-02 1:15 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090801215130.GA24201@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).