From: reinette chatre <reinette.chatre@intel.com>
To: Andrew Lutomirski <luto@mit.edu>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Zhu, Yi" <yi.zhu@intel.com>
Subject: Re: [PATCH 2.6.31] iwlwifi: Reenable power_level
Date: Wed, 02 Sep 2009 08:56:10 -0700 [thread overview]
Message-ID: <1251906970.13180.137.camel@rc-desk> (raw)
In-Reply-To: <cb0375e10909020753o4d314f61k74dd35025f61666a@mail.gmail.com>
Hi Andy,
On Wed, 2009-09-02 at 07:53 -0700, Andrew Lutomirski wrote:
> Right now, enabling power saving on iwlwifi is impossible, because
> mac80211 won't tell iwlwifi that power saving is on (since
> IEEE80211_HW_SUPPORTS_PS is not set) and iwlwifi will ignore the
> user's power_level setting until mac80211 asks for power saving.
> Setting this flag allows the user to manually enable power saving if
> desired.
>
> Signed-off-by: Andy Lutomirski <luto@mit.edu>
>
> ---
nack.
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=2053 and
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=2051 are two
examples of what happens if power save support is enabled. In addition
to this we are also seeing issues with 4965 that are described in the
commit that disabled powersave in 2.6.31 in the first place
(286d94906587901851906a5e2ddc09bc1a7ba1d9).
> This fixes what looks to me like a regression: power_level used to
> work but now fails silently. In 2.6.32 I think this code is going
> away, but this patch seems like a safe stopgap measure.
2.6.32 will have power save support disabled also.
Reinette
next prev parent reply other threads:[~2009-09-02 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 14:53 [PATCH 2.6.31] iwlwifi: Reenable power_level Andrew Lutomirski
2009-09-02 15:56 ` reinette chatre [this message]
2009-09-02 16:41 ` Andrew Lutomirski
2009-09-02 16:54 ` reinette chatre
2009-09-02 17:03 ` Johannes Berg
2009-09-02 17:17 ` reinette chatre
2009-09-02 17:30 ` Johannes Berg
2009-09-02 17:38 ` Andrew Lutomirski
2009-09-02 18:23 ` reinette chatre
2009-09-02 16:48 ` Johannes Berg
2009-09-02 16:57 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251906970.13180.137.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@mit.edu \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).