From: Andrew Lutomirski <luto@mit.edu>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: reinette chatre <reinette.chatre@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Zhu, Yi" <yi.zhu@intel.com>
Subject: Re: [PATCH 2.6.31] iwlwifi: Reenable power_level
Date: Wed, 2 Sep 2009 13:38:42 -0400 [thread overview]
Message-ID: <cb0375e10909021038k32a576f1hd519e8dcdff9ef3d@mail.gmail.com> (raw)
In-Reply-To: <1251912629.2999.1.camel@johannes.local>
On Wed, Sep 2, 2009 at 1:30 PM, Johannes Berg<johannes@sipsolutions.net> wrote:
> Hi Reinette,
>
>> The file itself was removed, but from what I understand the same
>> functionality can now be obtained from sleep_level_override.
>
> Indeed.
>
>> Users who
>> previously used power_level can thus now use sleep_level_override, but
>> with sleep_level_override not existing in 2.6.31 they will have no
>> alternative if we remove power_level.
>>
>> > So it
>> > may be fair to remove it for .31 since there you can't use it anyway.
>>
>> You can still use it to manually set power index used by device to
>> reduce power usage.
>
> I was under the impression that Andrew said this actually didn't work.
Exactly. My patch fixes that, although there might be a better way to do that.
--Andy
>
> johannes
>
next prev parent reply other threads:[~2009-09-02 17:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 14:53 [PATCH 2.6.31] iwlwifi: Reenable power_level Andrew Lutomirski
2009-09-02 15:56 ` reinette chatre
2009-09-02 16:41 ` Andrew Lutomirski
2009-09-02 16:54 ` reinette chatre
2009-09-02 17:03 ` Johannes Berg
2009-09-02 17:17 ` reinette chatre
2009-09-02 17:30 ` Johannes Berg
2009-09-02 17:38 ` Andrew Lutomirski [this message]
2009-09-02 18:23 ` reinette chatre
2009-09-02 16:48 ` Johannes Berg
2009-09-02 16:57 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0375e10909021038k32a576f1hd519e8dcdff9ef3d@mail.gmail.com \
--to=luto@mit.edu \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).