From: reinette chatre <reinette.chatre@intel.com>
To: Andrew Lutomirski <luto@mit.edu>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Zhu, Yi" <yi.zhu@intel.com>
Subject: Re: [PATCH 2.6.31] iwlwifi: Reenable power_level
Date: Wed, 02 Sep 2009 11:23:40 -0700 [thread overview]
Message-ID: <1251915820.13180.200.camel@rc-desk> (raw)
In-Reply-To: <cb0375e10909021038k32a576f1hd519e8dcdff9ef3d@mail.gmail.com>
On Wed, 2009-09-02 at 10:38 -0700, Andrew Lutomirski wrote:
> On Wed, Sep 2, 2009 at 1:30 PM, Johannes Berg<johannes@sipsolutions.net> wrote:
> >
> > I was under the impression that Andrew said this actually didn't work.
>
> Exactly. My patch fixes that, although there might be a better way to do that.
Seems to be in iwl_power_update_mode() the mode is forced to CAM if
power save disabled, and power save is set to disabled if mac considers
it disabled (see setting of power_disabled in iwl_mac_config()).
One way around this is to always allow user to set power mode, even if
it is disabled from mac perspective. Since the power mode is updated in
many more spots (not always triggered by user) I do not know the full
implications of this change. Considering the unknown of this change and
the problems we have encountered when enabling power save I would rather
not merge such a patch without significant testing. I think it is too
late for 2.6.31.
The same problem should not exist in 2.6.32.
Reinette
next prev parent reply other threads:[~2009-09-02 18:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 14:53 [PATCH 2.6.31] iwlwifi: Reenable power_level Andrew Lutomirski
2009-09-02 15:56 ` reinette chatre
2009-09-02 16:41 ` Andrew Lutomirski
2009-09-02 16:54 ` reinette chatre
2009-09-02 17:03 ` Johannes Berg
2009-09-02 17:17 ` reinette chatre
2009-09-02 17:30 ` Johannes Berg
2009-09-02 17:38 ` Andrew Lutomirski
2009-09-02 18:23 ` reinette chatre [this message]
2009-09-02 16:48 ` Johannes Berg
2009-09-02 16:57 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251915820.13180.200.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@mit.edu \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).