From: Johannes Berg <johannes@sipsolutions.net>
To: pradeepc@codeaurora.org
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/3] Add support for ftm responder configuration
Date: Thu, 16 Aug 2018 10:12:30 +0200 [thread overview]
Message-ID: <1534407150.3547.58.camel@sipsolutions.net> (raw)
In-Reply-To: <4aaa3a6185dbd116ba5c1a2ce76b691f@codeaurora.org>
On Wed, 2018-08-15 at 18:50 -0700, pradeepc@codeaurora.org wrote:
> > All you describe above is really a driver bug - it shouldn't have
> > enabled it to start with?
>
> Sure.. But isn't it justifiable for drivers/firmware choosing to enable
> ftm responder by default when there is no way for userspace to specify
> this parameter?
No? FTM needs higher-level configuration/advertisement, so how could the
driver/firmware enable it when it's not supposed to be?
I really do think this is a driver bug.
Nothing stopped you from submitting these patches months/years ago when
the capability was first added to the firmware, after all.
> > This makes sense anyway. Funny you should post this within hours of me
> > doing the same, basically.
>
> Sorry, I missed your patches before posting mine :)
No worries.
> >
> > I have no objection to your approach, though I guess it'd be nice if
> > you
> > could take a look at the statistics I have exposed and see if those
> > makes sense or if additional ones are desirable for you, and then we
> > can combine the work that way, i.e. have your configuration and our stats?
>
> I looked at the patch you posted and this makes sense. I will try to
> align ath10k driver changes with your approach.
I tend to actually like your patch better for configuration - no new
command, though it is, I think, lacking configuration of the necessary
elements (where do you take the LCI/Civic location from?).
johannes
next prev parent reply other threads:[~2018-08-16 11:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 0:30 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 1/3] nl80211: add support to configure FTM responder functionality Pradeep Kumar Chitrapu
2018-08-15 12:09 ` Johannes Berg
2018-08-16 1:48 ` pradeepc
2018-08-16 8:09 ` Johannes Berg
2018-08-31 1:10 ` [PATCH 1/3] cfg80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 2/3] mac80211: Add support to notify ftm responder configuration to the driver Pradeep Kumar Chitrapu
2018-08-15 12:09 ` Johannes Berg
2018-08-31 1:11 ` [PATCH 2/3] mac80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
2018-08-15 10:03 ` Sebastian Gottschall
2018-08-15 10:16 ` Sebastian Gottschall
2018-10-01 13:32 ` Kalle Valo
2018-11-16 12:17 ` Kalle Valo
2018-08-31 1:11 ` Pradeep Kumar Chitrapu
2018-08-15 9:04 ` [PATCH 0/3] Add support for ftm responder configuration Johannes Berg
2018-08-16 1:50 ` pradeepc
2018-08-16 8:12 ` Johannes Berg [this message]
2018-08-18 7:50 ` Pradeep Kumar Chitrapu
2018-08-20 9:33 ` Johannes Berg
2018-08-21 18:32 ` Pradeep Kumar Chitrapu
2018-08-21 19:24 ` Johannes Berg
2018-08-16 9:21 ` Kalle Valo
2018-08-31 1:10 ` [PATCH 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-21 22:08 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu
2018-08-22 7:27 ` Johannes Berg
2018-08-22 18:22 ` Pradeep Kumar Chitrapu
2018-08-28 8:43 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534407150.3547.58.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).