linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/3] Add support for ftm responder configuration
Date: Tue, 21 Aug 2018 21:24:19 +0200	[thread overview]
Message-ID: <1534879459.25523.48.camel@sipsolutions.net> (raw)
In-Reply-To: <dbd347a3434c05f48931559818dac8a1@codeaurora.org>

On Tue, 2018-08-21 at 11:32 -0700, Pradeep Kumar Chitrapu wrote:
> 
> I wasn't aware of this android api.

OK.

> However, looking at the api, the 
> assumption is that bss is started by a different
> api and the 'enableResponder' api is used for enabling rtt for a given 
> duration.

It looks like. Note that there's also *disable*, which we hadn't even
implemented before.

> The reason we have added enabling ftm responder through start ap is that 
> this can reflect beacon IE change in the
> configuration in the same place. 

Which makes sense, yeah.

> In case of the separate command, 
> enabling responder will not update the beacon,
> however, the application must issue the new command, whenever its 
> updating beacon template.

Right. However, I guess we could allow updating/changing this setting on
the fly through nl80211_set_beacon() which already allows changing other
non-beacon parameters (like the probe or assoc response templates), and
then we can use your approach. Basically changing "SET_BEACON" to be a
bit like "CHANGE_AP". In that case we definitely would need the
attribute to be 0/1 as you had it so that it not present can be used to
indicate "no change".

johannes

  reply	other threads:[~2018-08-21 22:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15  0:30 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu
2018-08-15  0:30 ` [PATCH 1/3] nl80211: add support to configure FTM responder functionality Pradeep Kumar Chitrapu
2018-08-15 12:09   ` Johannes Berg
2018-08-16  1:48     ` pradeepc
2018-08-16  8:09       ` Johannes Berg
2018-08-31  1:10   ` [PATCH 1/3] cfg80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-15  0:30 ` [PATCH 2/3] mac80211: Add support to notify ftm responder configuration to the driver Pradeep Kumar Chitrapu
2018-08-15 12:09   ` Johannes Berg
2018-08-31  1:11   ` [PATCH 2/3] mac80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-15  0:30 ` [PATCH 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
2018-08-15 10:03   ` Sebastian Gottschall
2018-08-15 10:16   ` Sebastian Gottschall
2018-10-01 13:32     ` Kalle Valo
2018-11-16 12:17       ` Kalle Valo
2018-08-31  1:11   ` Pradeep Kumar Chitrapu
2018-08-15  9:04 ` [PATCH 0/3] Add support for ftm responder configuration Johannes Berg
2018-08-16  1:50   ` pradeepc
2018-08-16  8:12     ` Johannes Berg
2018-08-18  7:50       ` Pradeep Kumar Chitrapu
2018-08-20  9:33         ` Johannes Berg
2018-08-21 18:32           ` Pradeep Kumar Chitrapu
2018-08-21 19:24             ` Johannes Berg [this message]
2018-08-16  9:21     ` Kalle Valo
2018-08-31  1:10 ` [PATCH 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-21 22:08 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu
2018-08-22  7:27 ` Johannes Berg
2018-08-22 18:22   ` Pradeep Kumar Chitrapu
2018-08-28  8:43     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1534879459.25523.48.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).