* [PATCH 10/11] net: qtnfmac: constify pci_device_id.
@ 2017-07-17 18:14 Arvind Yadav
2017-07-18 11:01 ` Sergey Matyukevich
2017-08-03 10:10 ` [10/11] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-07-17 18:14 UTC (permalink / raw)
To: imitsyanko, kvalo, avinashp, smatyukevich
Cc: netdev, linux-kernel, linux-wireless
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
index 7fc4f0d..02337d8 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
@@ -1336,7 +1336,7 @@ static SIMPLE_DEV_PM_OPS(qtnf_pcie_pm_ops, qtnf_pcie_suspend,
qtnf_pcie_resume);
#endif
-static struct pci_device_id qtnf_pcie_devid_table[] = {
+static const struct pci_device_id qtnf_pcie_devid_table[] = {
{
PCIE_VENDOR_ID_QUANTENNA, PCIE_DEVICE_ID_QTN_PEARL,
PCI_ANY_ID, PCI_ANY_ID, 0, 0,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 10/11] net: qtnfmac: constify pci_device_id.
2017-07-17 18:14 [PATCH 10/11] net: qtnfmac: constify pci_device_id Arvind Yadav
@ 2017-07-18 11:01 ` Sergey Matyukevich
2017-08-03 10:10 ` [10/11] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Matyukevich @ 2017-07-18 11:01 UTC (permalink / raw)
To: Arvind Yadav
Cc: imitsyanko, kvalo, avinashp, smatyukevich, netdev, linux-kernel,
linux-wireless
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
> index 7fc4f0d..02337d8 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
> @@ -1336,7 +1336,7 @@ static SIMPLE_DEV_PM_OPS(qtnf_pcie_pm_ops, qtnf_pcie_suspend,
> qtnf_pcie_resume);
> #endif
>
> -static struct pci_device_id qtnf_pcie_devid_table[] = {
> +static const struct pci_device_id qtnf_pcie_devid_table[] = {
> {
> PCIE_VENDOR_ID_QUANTENNA, PCIE_DEVICE_ID_QTN_PEARL,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> --
> 2.7.4
Thanks !
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [10/11] net: qtnfmac: constify pci_device_id.
2017-07-17 18:14 [PATCH 10/11] net: qtnfmac: constify pci_device_id Arvind Yadav
2017-07-18 11:01 ` Sergey Matyukevich
@ 2017-08-03 10:10 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-08-03 10:10 UTC (permalink / raw)
To: Arvind Yadav
Cc: imitsyanko, avinashp, smatyukevich, netdev, linux-kernel, linux-wireless
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
cc5becd38e87 net: qtnfmac: constify pci_device_id.
--
https://patchwork.kernel.org/patch/9845911/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-03 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 18:14 [PATCH 10/11] net: qtnfmac: constify pci_device_id Arvind Yadav
2017-07-18 11:01 ` Sergey Matyukevich
2017-08-03 10:10 ` [10/11] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).