* [PATCH] NFC: pn533: mark expected switch fall-throughs
@ 2018-10-05 7:20 Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-05 7:20 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-wireless, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1230487 ("Missing break in switch")
Addresses-Coverity-ID: 1230488 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/nfc/pn533/pn533.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c
index a0cc1cc..5961f14 100644
--- a/drivers/nfc/pn533/pn533.c
+++ b/drivers/nfc/pn533/pn533.c
@@ -2147,6 +2147,7 @@ static int pn533_transceive(struct nfc_dev *nfc_dev,
break;
}
+ /* fall through */
default:
/* jumbo frame ? */
if (skb->len > PN533_CMD_DATAEXCH_DATA_MAXLEN) {
@@ -2273,6 +2274,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)
break;
}
+ /* fall through */
default:
skb_put_u8(skb, 1); /*TG*/
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] NFC: pn533: mark expected switch fall-throughs
@ 2019-02-13 18:57 Gustavo A. R. Silva
2019-03-20 19:21 ` Gustavo A. R. Silva
2019-04-09 16:29 ` Kees Cook
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-13 18:57 UTC (permalink / raw)
To: Samuel Ortiz, Kees Cook; +Cc: linux-wireless, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:
drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
^
drivers/nfc/pn533/pn533.c:2150:2: note: here
default:
^~~~~~~
drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:
drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
^
drivers/nfc/pn533/pn533.c:2276:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Addresses-Coverity-ID: 1230487 ("Missing break in switch")
Addresses-Coverity-ID: 1230488 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/nfc/pn533/pn533.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c
index a0cc1cc45292..5961f14259e5 100644
--- a/drivers/nfc/pn533/pn533.c
+++ b/drivers/nfc/pn533/pn533.c
@@ -2147,6 +2147,7 @@ static int pn533_transceive(struct nfc_dev *nfc_dev,
break;
}
+ /* fall through */
default:
/* jumbo frame ? */
if (skb->len > PN533_CMD_DATAEXCH_DATA_MAXLEN) {
@@ -2273,6 +2274,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)
break;
}
+ /* fall through */
default:
skb_put_u8(skb, 1); /*TG*/
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] NFC: pn533: mark expected switch fall-throughs
2019-02-13 18:57 Gustavo A. R. Silva
@ 2019-03-20 19:21 ` Gustavo A. R. Silva
2019-04-09 16:29 ` Kees Cook
1 sibling, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 19:21 UTC (permalink / raw)
To: Samuel Ortiz, Kees Cook; +Cc: linux-wireless, linux-kernel
Hi all,
If no one cares, I'll add this to my tree for 5.2
Thanks
--
Gustavo
On 2/13/19 12:57 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:
> drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
> ^
> drivers/nfc/pn533/pn533.c:2150:2: note: here
> default:
> ^~~~~~~
> drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:
> drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
> ^
> drivers/nfc/pn533/pn533.c:2276:2: note: here
> default:
> ^~~~~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Addresses-Coverity-ID: 1230487 ("Missing break in switch")
> Addresses-Coverity-ID: 1230488 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/nfc/pn533/pn533.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c
> index a0cc1cc45292..5961f14259e5 100644
> --- a/drivers/nfc/pn533/pn533.c
> +++ b/drivers/nfc/pn533/pn533.c
> @@ -2147,6 +2147,7 @@ static int pn533_transceive(struct nfc_dev *nfc_dev,
>
> break;
> }
> + /* fall through */
> default:
> /* jumbo frame ? */
> if (skb->len > PN533_CMD_DATAEXCH_DATA_MAXLEN) {
> @@ -2273,6 +2274,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)
>
> break;
> }
> + /* fall through */
> default:
> skb_put_u8(skb, 1); /*TG*/
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] NFC: pn533: mark expected switch fall-throughs
2019-02-13 18:57 Gustavo A. R. Silva
2019-03-20 19:21 ` Gustavo A. R. Silva
@ 2019-04-09 16:29 ` Kees Cook
1 sibling, 0 replies; 4+ messages in thread
From: Kees Cook @ 2019-04-09 16:29 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Samuel Ortiz, linux-wireless, LKML
On Wed, Feb 13, 2019 at 10:57 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:
> drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
> ^
> drivers/nfc/pn533/pn533.c:2150:2: note: here
> default:
> ^~~~~~~
> drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:
> drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
> ^
> drivers/nfc/pn533/pn533.c:2276:2: note: here
> default:
> ^~~~~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Addresses-Coverity-ID: 1230487 ("Missing break in switch")
> Addresses-Coverity-ID: 1230488 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-09 16:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 7:20 [PATCH] NFC: pn533: mark expected switch fall-throughs Gustavo A. R. Silva
2019-02-13 18:57 Gustavo A. R. Silva
2019-03-20 19:21 ` Gustavo A. R. Silva
2019-04-09 16:29 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).