* [PATCH] net: brcm80211: add a check for the status of usb_register
@ 2018-12-26 1:22 Kangjie Lu
2019-01-08 16:43 ` Kalle Valo
2019-01-10 11:38 ` [PATCH] brcmfmac: " Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Kangjie Lu @ 2018-12-26 1:22 UTC (permalink / raw)
To: kjlu
Cc: pakki001, Arend van Spriel, Franky Lin, Hante Meuleman,
Chi-Hsien Lin, Wright Feng, Kalle Valo, David S. Miller,
Pieter-Paul Giesberts, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, linux-kernel
usb_register() may fail, so let's check its status and issue an error
message if it fails.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index a4308c6e72d7..76cfaf6999c8 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
@@ -1550,6 +1550,10 @@ void brcmf_usb_exit(void)
void brcmf_usb_register(void)
{
+ int ret;
+
brcmf_dbg(USB, "Enter\n");
- usb_register(&brcmf_usbdrvr);
+ ret = usb_register(&brcmf_usbdrvr);
+ if (ret)
+ brcmf_err("usb_register failed %d\n", ret);
}
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: brcm80211: add a check for the status of usb_register
2018-12-26 1:22 [PATCH] net: brcm80211: add a check for the status of usb_register Kangjie Lu
@ 2019-01-08 16:43 ` Kalle Valo
2019-01-09 8:28 ` Arend Van Spriel
2019-01-10 11:38 ` [PATCH] brcmfmac: " Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2019-01-08 16:43 UTC (permalink / raw)
To: Kangjie Lu
Cc: pakki001, Arend van Spriel, Franky Lin, Hante Meuleman,
Chi-Hsien Lin, Wright Feng, David S. Miller,
Pieter-Paul Giesberts, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, linux-kernel
Kangjie Lu <kjlu@umn.edu> writes:
> usb_register() may fail, so let's check its status and issue an error
> message if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++-
The title prefix should be "brcmfmac: " but I can fix that.
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: brcm80211: add a check for the status of usb_register
2019-01-08 16:43 ` Kalle Valo
@ 2019-01-09 8:28 ` Arend Van Spriel
2019-01-09 11:17 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Arend Van Spriel @ 2019-01-09 8:28 UTC (permalink / raw)
To: Kalle Valo, Kangjie Lu
Cc: pakki001, Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
David S. Miller, Pieter-Paul Giesberts, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, netdev, linux-kernel
On 1/8/2019 5:43 PM, Kalle Valo wrote:
> Kangjie Lu <kjlu@umn.edu> writes:
>
>> usb_register() may fail, so let's check its status and issue an error
>> message if it fails.
>>
>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>> ---
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++-
>
> The title prefix should be "brcmfmac: " but I can fix that.
Hi Kalle,
I wanted to ack this patch, but can not locate it in my email not in
linux-wireless patchwork. Was it posted to the networking list only?
Using scripts/get_maintainer.pl with the patch would reveal the lists to
post to in order of preference. For wireless driver changes I refrain to
linux-wireless only, but that is a personal choice I guess.
Regards,
Arend
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: brcm80211: add a check for the status of usb_register
2019-01-09 8:28 ` Arend Van Spriel
@ 2019-01-09 11:17 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2019-01-09 11:17 UTC (permalink / raw)
To: Arend Van Spriel
Cc: Kangjie Lu, pakki001, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, David S. Miller, Pieter-Paul Giesberts,
linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list,
netdev, linux-kernel
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On 1/8/2019 5:43 PM, Kalle Valo wrote:
>> Kangjie Lu <kjlu@umn.edu> writes:
>>
>>> usb_register() may fail, so let's check its status and issue an error
>>> message if it fails.
>>>
>>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>>> ---
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++-
>>
>> The title prefix should be "brcmfmac: " but I can fix that.
>
> Hi Kalle,
>
> I wanted to ack this patch, but can not locate it in my email not in
> linux-wireless patchwork. Was it posted to the networking list only?
I do see it on linux-wireless patchwork:
https://patchwork.kernel.org/patch/10742769/
> Using scripts/get_maintainer.pl with the patch would reveal the lists
> to post to in order of preference. For wireless driver changes I
> refrain to linux-wireless only, but that is a personal choice I guess.
Yeah, I guess in general wireless patches are just noise for netdev
people.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: add a check for the status of usb_register
2018-12-26 1:22 [PATCH] net: brcm80211: add a check for the status of usb_register Kangjie Lu
2019-01-08 16:43 ` Kalle Valo
@ 2019-01-10 11:38 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2019-01-10 11:38 UTC (permalink / raw)
To: Kangjie Lu
Cc: kjlu, pakki001, Arend van Spriel, Franky Lin, Hante Meuleman,
Chi-Hsien Lin, Wright Feng, David S. Miller,
Pieter-Paul Giesberts, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, linux-kernel
Kangjie Lu <kjlu@umn.edu> wrote:
> usb_register() may fail, so let's check its status and issue an error
> message if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Patch applied to wireless-drivers-next.git, thanks.
42daad3343be brcmfmac: add a check for the status of usb_register
--
https://patchwork.kernel.org/patch/10742769/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-10 11:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-26 1:22 [PATCH] net: brcm80211: add a check for the status of usb_register Kangjie Lu
2019-01-08 16:43 ` Kalle Valo
2019-01-09 8:28 ` Arend Van Spriel
2019-01-09 11:17 ` Kalle Valo
2019-01-10 11:38 ` [PATCH] brcmfmac: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).