* [PATCH] rtw88: fix seq_file memory leak
@ 2019-09-04 14:16 Wei Yongjun
2019-09-06 14:10 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2019-09-04 14:16 UTC (permalink / raw)
To: Yan-Hsuan Chuang, Kalle Valo; +Cc: Wei Yongjun, linux-wireless, kernel-janitors
When using single_open(), single_release() should be used instead
of seq_release(), otherwise there is a memory leak.
This is detected by Coccinelle semantic patch.
Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index f0ae26018f97..a7d45f4d34c4 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -76,7 +76,7 @@ static const struct file_operations file_ops_single_r = {
.open = rtw_debugfs_single_open_rw,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};
static const struct file_operations file_ops_single_rw = {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-06 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 14:16 [PATCH] rtw88: fix seq_file memory leak Wei Yongjun
2019-09-06 14:10 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).