* [PATCH -next] rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static
@ 2020-07-21 13:49 Wei Yongjun
2020-08-02 15:06 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-21 13:49 UTC (permalink / raw)
To: Hulk Robot, Yan-Hsuan Chuang, Kalle Valo, Jakub Kicinski, Tzu-En Huang
Cc: Wei Yongjun, linux-wireless
The sparse tool complains as follows:
drivers/net/wireless/realtek/rtw88/rtw8821c.c:1374:32: warning:
symbol 'rtw8821c_rtw_pwr_track_tbl' was not declared. Should it be static?
This variable is not used outside of rtw8821c.c, so this commit
marks it static.
Fixes: 3a4312828ce1 ("rtw88: 8821c: add power tracking")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index c41c61ee2fb6..5fef19f19ac1 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -1371,7 +1371,7 @@ static const u8 rtw8821c_pwrtrk_2g_cck_a_p[] = {
5, 6, 6, 7, 7, 7, 8, 8, 9, 9, 9, 9, 9, 9
};
-const struct rtw_pwr_track_tbl rtw8821c_rtw_pwr_track_tbl = {
+static const struct rtw_pwr_track_tbl rtw8821c_rtw_pwr_track_tbl = {
.pwrtrk_5gb_n[0] = rtw8821c_pwrtrk_5gb_n[0],
.pwrtrk_5gb_n[1] = rtw8821c_pwrtrk_5gb_n[1],
.pwrtrk_5gb_n[2] = rtw8821c_pwrtrk_5gb_n[2],
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static
2020-07-21 13:49 [PATCH -next] rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static Wei Yongjun
@ 2020-08-02 15:06 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-08-02 15:06 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Yan-Hsuan Chuang, Jakub Kicinski, Tzu-En Huang,
Wei Yongjun, linux-wireless
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> The sparse tool complains as follows:
>
> drivers/net/wireless/realtek/rtw88/rtw8821c.c:1374:32: warning:
> symbol 'rtw8821c_rtw_pwr_track_tbl' was not declared. Should it be static?
>
> This variable is not used outside of rtw8821c.c, so this commit
> marks it static.
>
> Fixes: 3a4312828ce1 ("rtw88: 8821c: add power tracking")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
9de6959f8584 rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static
--
https://patchwork.kernel.org/patch/11675705/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-02 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 13:49 [PATCH -next] rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static Wei Yongjun
2020-08-02 15:06 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).