* [PATCH] ath11k: remove redundant assignment to variables vht_mcs and he_mcs
@ 2022-05-07 18:41 Colin Ian King
2022-05-10 16:34 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-05-07 18:41 UTC (permalink / raw)
To: Kalle Valo, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, ath11k, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel, llvm
The variables vht_mcs and he_mcs are being initialized in the
start of for-loops however they are re-assigned new values in
the loop and not used outside the loop. The initializations
are redundant and can be removed.
Cleans up clang scan warnings:
warning: Although the value stored to 'vht_mcs' is used in the
enclosing expression, the value is never actually read from
'vht_mcs' [deadcode.DeadStores]
warning: Although the value stored to 'he_mcs' is used in the
enclosing expression, the value is never actually read from
'he_mcs' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 1957e1713548..014eaabb3af4 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -1951,7 +1951,7 @@ static void ath11k_peer_assoc_h_vht(struct ath11k *ar,
/* Calculate peer NSS capability from VHT capabilities if STA
* supports VHT.
*/
- for (i = 0, max_nss = 0, vht_mcs = 0; i < NL80211_VHT_NSS_MAX; i++) {
+ for (i = 0, max_nss = 0; i < NL80211_VHT_NSS_MAX; i++) {
vht_mcs = __le16_to_cpu(vht_cap->vht_mcs.rx_mcs_map) >>
(2 * i) & 3;
@@ -2272,7 +2272,7 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar,
/* Calculate peer NSS capability from HE capabilities if STA
* supports HE.
*/
- for (i = 0, max_nss = 0, he_mcs = 0; i < NL80211_HE_NSS_MAX; i++) {
+ for (i = 0, max_nss = 0; i < NL80211_HE_NSS_MAX; i++) {
he_mcs = he_tx_mcs >> (2 * i) & 3;
/* In case of fixed rates, MCS Range in he_tx_mcs might have
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath11k: remove redundant assignment to variables vht_mcs and he_mcs
2022-05-07 18:41 [PATCH] ath11k: remove redundant assignment to variables vht_mcs and he_mcs Colin Ian King
@ 2022-05-10 16:34 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-05-10 16:34 UTC (permalink / raw)
To: Colin Ian King
Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
ath11k, linux-wireless, netdev, kernel-janitors, linux-kernel,
llvm
Colin Ian King <colin.i.king@gmail.com> wrote:
> The variables vht_mcs and he_mcs are being initialized in the
> start of for-loops however they are re-assigned new values in
> the loop and not used outside the loop. The initializations
> are redundant and can be removed.
>
> Cleans up clang scan warnings:
>
> warning: Although the value stored to 'vht_mcs' is used in the
> enclosing expression, the value is never actually read from
> 'vht_mcs' [deadcode.DeadStores]
>
> warning: Although the value stored to 'he_mcs' is used in the
> enclosing expression, the value is never actually read from
> 'he_mcs' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
25c321e8534e ath11k: remove redundant assignment to variables vht_mcs and he_mcs
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220507184155.26939-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-10 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 18:41 [PATCH] ath11k: remove redundant assignment to variables vht_mcs and he_mcs Colin Ian King
2022-05-10 16:34 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).