From: Johannes Berg <johannes@sipsolutions.net>
To: Alexander Wetzel <alexander@wetzel-home.de>, luciano.coelho@intel.com
Cc: linux-wireless@vger.kernel.org, linuxwifi@intel.com
Subject: Re: [PATCH] iwlwifi: Extended Key ID support for mvm and dvm
Date: Mon, 19 Aug 2019 20:51:03 +0200 [thread overview]
Message-ID: <204c346ab9fc71865e4cb5f5c29ec33ca05050e2.camel@sipsolutions.net> (raw)
In-Reply-To: <20190819180540.2855-1-alexander@wetzel-home.de>
On Mon, 2019-08-19 at 20:05 +0200, Alexander Wetzel wrote:
> All iwlwifi cards below the 22000 series are able to handle multiple
> keyids per STA and allow the selection of the encryption key per MPDU.
>
> These are therefore fully compatible with the Extended Key ID support
> implementation in mac80211.
>
> Enable Extended Key ID support for all dvm cards and the mvm cards not
> using the incompatible new Tx API introduced for the 22000 series.
>
> Signed-off-by: Alexander Wetzel <alexander@wetzel-home.de>
LGTM.
> +
> + /* The new Tx API does not allow to pass the key or keyid of a MPDU to
> + * the hw, preventing us to control which key(id) to use per MPDU.
> + * Till that's fixed we can't use Extended Key ID for the newer cards.
Technically we still don't need per MPDU, we just need to switch which
one to use for TX after installing it for RX already.
johannes
next prev parent reply other threads:[~2019-08-19 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 18:05 [PATCH] iwlwifi: Extended Key ID support for mvm and dvm Alexander Wetzel
2019-08-19 18:51 ` Johannes Berg [this message]
2019-08-19 19:57 ` Alexander Wetzel
2019-08-19 20:03 ` Johannes Berg
2019-08-19 20:09 ` Johannes Berg
2019-08-19 20:50 ` Alexander Wetzel
2019-08-19 20:42 ` Alexander Wetzel
2019-09-06 20:41 ` Alexander Wetzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204c346ab9fc71865e4cb5f5c29ec33ca05050e2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alexander@wetzel-home.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).