From: Alexander Wetzel <alexander@wetzel-home.de>
To: Johannes Berg <johannes@sipsolutions.net>, luciano.coelho@intel.com
Cc: linux-wireless@vger.kernel.org, linuxwifi@intel.com
Subject: Re: [PATCH] iwlwifi: Extended Key ID support for mvm and dvm
Date: Mon, 19 Aug 2019 22:50:45 +0200 [thread overview]
Message-ID: <9e63e06d-48ef-e7aa-638a-b551a208665f@wetzel-home.de> (raw)
In-Reply-To: <5bc077f7b2f017da7c027edd27a543910dd6ac32.camel@sipsolutions.net>
Am 19.08.19 um 22:09 schrieb Johannes Berg:
> On Mon, 2019-08-19 at 22:03 +0200, Johannes Berg wrote:
>>
>>> While less desirable we still could get that working: The mvm driver
>>> would have to detect the key borders and then tell the firmware to
>>> switch over to the other key. But we would have to make sure to not
>>> re-enable A-MPDU aggregation till the card really has switched.
>
>> So probably you're right, and we'd have to disable A-MPDUs until we have
>> no outstanding old-key-retransmits, but that seems manageable.
>
> Actually, we probably have to even delay the key switch until there are
> no more frames to retransmit, because the hardware is involved to some
> extent and it won't know about two keys or something... Not really sure
> how it all works though, off the top of my head.
This sounds like the card is not really able to handle two unicast key
per STA, which would be a show stopper.
But not sure if I can believe that: After all the card is setting the
correct keyid for the key and e.g. able to use keyid 1 for both send and
receive, so it's not simply assuming unicast keys are always using keyid 0.
Honoring the keyid for that but then not be able to differentiate
between the keyids for re-transmits is nothing I would have expected. So
I still hope you are wrong here:-)
Alexander
next prev parent reply other threads:[~2019-08-19 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 18:05 [PATCH] iwlwifi: Extended Key ID support for mvm and dvm Alexander Wetzel
2019-08-19 18:51 ` Johannes Berg
2019-08-19 19:57 ` Alexander Wetzel
2019-08-19 20:03 ` Johannes Berg
2019-08-19 20:09 ` Johannes Berg
2019-08-19 20:50 ` Alexander Wetzel [this message]
2019-08-19 20:42 ` Alexander Wetzel
2019-09-06 20:41 ` Alexander Wetzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e63e06d-48ef-e7aa-638a-b551a208665f@wetzel-home.de \
--to=alexander@wetzel-home.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).