From: Sathishkumar Muruganandam <murugana@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: enable TKIP when using encapsulation offloading
Date: Fri, 29 May 2020 20:21:42 +0530 [thread overview]
Message-ID: <21fcffb4db13e9f0b70669d2e7f97d8a@codeaurora.org> (raw)
In-Reply-To: <86c1e5d23093f350bdabdde4c305c33ecde06b3b.camel@sipsolutions.net>
On 2020-05-29 20:14, Johannes Berg wrote:
> On Fri, 2020-05-29 at 20:10 +0530, Sathishkumar Muruganandam wrote:
>> On 2020-05-29 18:16, Johannes Berg wrote:
>> > On Fri, 2020-05-29 at 17:59 +0530, Sathishkumar Muruganandam wrote:
>> > > Yes, currently only tx encap support is added and rx decap support is
>> > > in
>> > > progress to do TKIP MIC error reporting to userspace via
>> > > cfg80211_michael_mic_failure().
>> >
>> > Yes, but can you actually call that? It requires a netdev. I don't
>> > think
>> > you can easily get it from the vif?
>> >
>>
>> Yes, that's right. Currently the plan is to add new mac80211 api for
>> rx
>> decap where
>> we can call cfg80211_michael_mic_failure() and not called directly
>> from
>> driver.
>
> Sure, that sounds fine.
>
> Really what I was saying is that we should have that together, not just
> this patch that allows TKIP offload, but then nothing that actually
> makes that working properly/safely.
Sure, thanks Johannes !
Will include this along with rx decap patch.
>
>> Whether we can expose netdev to driver for doing such cfg80211 call ?
>
> I've always worried that if we expose the netdev we'll just get all
> kinds of messy things happening in the driver :)
>
> But maybe not. I guess it doesn't make a big difference.
>
Sure, will fallback to mac80211 approach for rx decap. Thanks for your
review !
Thanks,
Sathishkumar
next prev parent reply other threads:[~2020-05-29 14:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:35 [PATCH 0/2] mac80211: enable TKIP when using encapsulation offloading Sathishkumar Muruganandam
2020-04-24 9:35 ` [PATCH 1/2] " Sathishkumar Muruganandam
2020-05-26 12:44 ` Johannes Berg
2020-05-29 12:08 ` Sathishkumar Muruganandam
2020-05-29 12:10 ` Johannes Berg
2020-05-29 12:29 ` Sathishkumar Muruganandam
2020-05-29 12:46 ` Johannes Berg
2020-05-29 14:40 ` Sathishkumar Muruganandam
2020-05-29 14:44 ` Johannes Berg
2020-05-29 14:51 ` Sathishkumar Muruganandam [this message]
2020-04-24 9:35 ` [PATCH 2/2] ath11k: add 802.3 undecap support to fix TKIP MIC error reporting Sathishkumar Muruganandam
2020-05-29 14:42 ` Kalle Valo
2020-04-24 9:47 ` [PATCH 0/2] mac80211: enable TKIP when using encapsulation offloading Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21fcffb4db13e9f0b70669d2e7f97d8a@codeaurora.org \
--to=murugana@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).