From: Sathishkumar Muruganandam <murugana@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: enable TKIP when using encapsulation offloading
Date: Fri, 29 May 2020 17:59:51 +0530 [thread overview]
Message-ID: <4bab3197997bb2dd6555ff920c5dd1cb@codeaurora.org> (raw)
In-Reply-To: <aaa53c3a9cf6788cb653eb574073a1a0bcc5e6bf.camel@sipsolutions.net>
On 2020-05-29 17:40, Johannes Berg wrote:
> On Fri, 2020-05-29 at 17:38 +0530, Sathishkumar Muruganandam wrote:
>
>> > I don't think it can. It doesn't have all the necessary information to
>> > call cfg80211_michael_mic_failure(), as far as I can tell.
>>
>> Ath11k HW has capability of reporting TKIP MIC error when hw encap is
>> enabled as well, so TKIP encryption shall be enabled.
>
> Maybe so. But it cannot tell wpa_supplicant about MIC errors, and so
> that cannot do countermeasures, so something isn't right.
>
>> Shall we have a ieee80211_hw_flags for the driver to advertise TKIP
>> MIC
>> error reporting capability when hw encap is enabled ?
>> TKIP bring-up will be disabled for the drivers which doesn't have the
>> capability.
>
> That would be better, since for TKIP it's actually more tricky and
> requires more work.
>
> But mostly I was thinking that you should make it possible for ath11k
> to
> actually report the MIC errors up to userspace. Right now I don't think
> it can, because it doesn't have the netdev pointer?
>
Yes, currently only tx encap support is added and rx decap support is in
progress to do TKIP MIC error reporting to userspace via
cfg80211_michael_mic_failure().
With NL80211_CMD_MICHAEL_MIC_FAILURE, hostapd will be able to do TKIP
counter-measures.
Thanks,
Sathishkumar
next prev parent reply other threads:[~2020-05-29 12:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:35 [PATCH 0/2] mac80211: enable TKIP when using encapsulation offloading Sathishkumar Muruganandam
2020-04-24 9:35 ` [PATCH 1/2] " Sathishkumar Muruganandam
2020-05-26 12:44 ` Johannes Berg
2020-05-29 12:08 ` Sathishkumar Muruganandam
2020-05-29 12:10 ` Johannes Berg
2020-05-29 12:29 ` Sathishkumar Muruganandam [this message]
2020-05-29 12:46 ` Johannes Berg
2020-05-29 14:40 ` Sathishkumar Muruganandam
2020-05-29 14:44 ` Johannes Berg
2020-05-29 14:51 ` Sathishkumar Muruganandam
2020-04-24 9:35 ` [PATCH 2/2] ath11k: add 802.3 undecap support to fix TKIP MIC error reporting Sathishkumar Muruganandam
2020-05-29 14:42 ` Kalle Valo
2020-04-24 9:47 ` [PATCH 0/2] mac80211: enable TKIP when using encapsulation offloading Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bab3197997bb2dd6555ff920c5dd1cb@codeaurora.org \
--to=murugana@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).