From: Sathishkumar Muruganandam <murugana@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: enable TKIP when using encapsulation offloading
Date: Fri, 29 May 2020 17:38:17 +0530 [thread overview]
Message-ID: <7fb606edf1e5c7ab5b1446d637768ee7@codeaurora.org> (raw)
In-Reply-To: <d4e39180f0a8a8b07dc558c9439b66cd2c3aec07.camel@sipsolutions.net>
On 2020-05-26 18:14, Johannes Berg wrote:
> On Fri, 2020-04-24 at 15:05 +0530, Sathishkumar Muruganandam wrote:
>> TKIP was disabled on encap offload mode since if TKIP MIC error
>> reporting is not capable by the driver using encap offload mode,
>> then TKIP countermeasures wont work.
>>
>> Enabling back TKIP bring-up in encap offload mode to leave the
>> control with the driver to disable hw encap when it is not capable
>> of TKIP MIC error reporting.
>
> So how can the driver do TKIP MIC error reporting?
>
> I don't think it can. It doesn't have all the necessary information to
> call cfg80211_michael_mic_failure(), as far as I can tell.
Ath11k HW has capability of reporting TKIP MIC error when hw encap is
enabled as well, so TKIP encryption shall be enabled.
>
> I'm not applying this until I see at least the *ability* for drivers to
> do it. I mean, I don't really want to worry about your driver's
> correctness, but if you then turn around and realize that you *cannot*
> actually implement the right behaviour, that's no good either.
>
Shall we have a ieee80211_hw_flags for the driver to advertise TKIP MIC
error reporting capability when hw encap is enabled ?
TKIP bring-up will be disabled for the drivers which doesn't have the
capability.
--
Sathishkumar
next prev parent reply other threads:[~2020-05-29 12:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:35 [PATCH 0/2] mac80211: enable TKIP when using encapsulation offloading Sathishkumar Muruganandam
2020-04-24 9:35 ` [PATCH 1/2] " Sathishkumar Muruganandam
2020-05-26 12:44 ` Johannes Berg
2020-05-29 12:08 ` Sathishkumar Muruganandam [this message]
2020-05-29 12:10 ` Johannes Berg
2020-05-29 12:29 ` Sathishkumar Muruganandam
2020-05-29 12:46 ` Johannes Berg
2020-05-29 14:40 ` Sathishkumar Muruganandam
2020-05-29 14:44 ` Johannes Berg
2020-05-29 14:51 ` Sathishkumar Muruganandam
2020-04-24 9:35 ` [PATCH 2/2] ath11k: add 802.3 undecap support to fix TKIP MIC error reporting Sathishkumar Muruganandam
2020-05-29 14:42 ` Kalle Valo
2020-04-24 9:47 ` [PATCH 0/2] mac80211: enable TKIP when using encapsulation offloading Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fb606edf1e5c7ab5b1446d637768ee7@codeaurora.org \
--to=murugana@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).