From: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
To: Ohad Ben-Cohen <ohad@wizery.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Cc: Ido Yariv <ido@wizery.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>,
Luciano Coelho <luciano.coelho@nokia.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
San Mehat <san@google.com>,
Roger Quadros <roger.quadros@nokia.com>,
Tony Lindgren <tony@atomide.com>,
Nicolas Pitre <nico@fluxnic.net>,
"Pandita, Vikram" <vikram.pandita@ti.com>,
Kalle Valo <kalle.valo@iki.fi>
Subject: RE: [PATCH v4 2/8] wireless: wl1271: support return value for the set power func
Date: Thu, 12 Aug 2010 00:05:04 +0530 [thread overview]
Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB0324110ABB@dbde02.ent.ti.com> (raw)
In-Reply-To: <1281550913-17633-3-git-send-email-ohad@wizery.com>
Ohad,
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Ohad Ben-Cohen
> Sent: Wednesday, August 11, 2010 11:52 PM
> To: linux-wireless@vger.kernel.org; linux-mmc@vger.kernel.org; linux-
> omap@vger.kernel.org
> Cc: Ido Yariv; Mark Brown; linux-arm-kernel@lists.infradead.org;
> Chikkature Rajashekar, Madhusudhan; Luciano Coelho; akpm@linux-
> foundation.org; San Mehat; Roger Quadros; Tony Lindgren; Nicolas Pitre;
> Pandita, Vikram; Kalle Valo; Ohad Ben-Cohen
> Subject: [PATCH v4 2/8] wireless: wl1271: support return value for the set
> power func
>
> Make it possible for the set power method to indicate a
> success/failure return value. This is needed to support
> more complex power on/off operations such as bringing up
> (and down) sdio functions.
>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> drivers/net/wireless/wl12xx/wl1271.h | 2 +-
> drivers/net/wireless/wl12xx/wl1271_io.h | 8 +++++---
> drivers/net/wireless/wl12xx/wl1271_main.c | 4 +++-
> drivers/net/wireless/wl12xx/wl1271_sdio.c | 4 +++-
> drivers/net/wireless/wl12xx/wl1271_spi.c | 4 +++-
> 5 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271.h
> b/drivers/net/wireless/wl12xx/wl1271.h
> index dd3cee6..faa5925 100644
> --- a/drivers/net/wireless/wl12xx/wl1271.h
> +++ b/drivers/net/wireless/wl12xx/wl1271.h
> @@ -313,7 +313,7 @@ struct wl1271_if_operations {
> bool fixed);
> void (*reset)(struct wl1271 *wl);
> void (*init)(struct wl1271 *wl);
> - void (*power)(struct wl1271 *wl, bool enable);
> + int (*power)(struct wl1271 *wl, bool enable);
> struct device* (*dev)(struct wl1271 *wl);
> void (*enable_irq)(struct wl1271 *wl);
> void (*disable_irq)(struct wl1271 *wl);
> diff --git a/drivers/net/wireless/wl12xx/wl1271_io.h
> b/drivers/net/wireless/wl12xx/wl1271_io.h
> index bc806c7..4a5b92c 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_io.h
> +++ b/drivers/net/wireless/wl12xx/wl1271_io.h
> @@ -144,10 +144,12 @@ static inline void wl1271_power_off(struct wl1271
> *wl)
> clear_bit(WL1271_FLAG_GPIO_POWER, &wl->flags);
> }
>
> -static inline void wl1271_power_on(struct wl1271 *wl)
> +static inline int wl1271_power_on(struct wl1271 *wl)
> {
> - wl->if_ops->power(wl, true);
> - set_bit(WL1271_FLAG_GPIO_POWER, &wl->flags);
> + int ret = wl->if_ops->power(wl, true);
Just a minor comment, need a blank line here?
> + if (ret == 0)
> + set_bit(WL1271_FLAG_GPIO_POWER, &wl->flags);
> + return ret;
> }
>
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c
> b/drivers/net/wireless/wl12xx/wl1271_main.c
> index 9d68f00..e6e0852 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_main.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c
> @@ -621,7 +621,9 @@ static int wl1271_chip_wakeup(struct wl1271 *wl)
> int ret = 0;
>
> msleep(WL1271_PRE_POWER_ON_SLEEP);
> - wl1271_power_on(wl);
> + ret = wl1271_power_on(wl);
> + if (ret < 0)
> + goto out;
> msleep(WL1271_POWER_ON_SLEEP);
> wl1271_io_reset(wl);
> wl1271_io_init(wl);
> diff --git a/drivers/net/wireless/wl12xx/wl1271_sdio.c
> b/drivers/net/wireless/wl12xx/wl1271_sdio.c
> index 7059b5c..c41293a 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_sdio.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_sdio.c
> @@ -152,7 +152,7 @@ static void wl1271_sdio_raw_write(struct wl1271 *wl,
> int addr, void *buf,
>
> }
>
> -static void wl1271_sdio_set_power(struct wl1271 *wl, bool enable)
> +static int wl1271_sdio_set_power(struct wl1271 *wl, bool enable)
> {
> struct sdio_func *func = wl_to_func(wl);
>
> @@ -167,6 +167,8 @@ static void wl1271_sdio_set_power(struct wl1271 *wl,
> bool enable)
> sdio_disable_func(func);
> sdio_release_host(func);
> }
> +
> + return 0;
> }
>
> static struct wl1271_if_operations sdio_ops = {
> diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c
> b/drivers/net/wireless/wl12xx/wl1271_spi.c
> index c3fdab7..de56d8d 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_spi.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_spi.c
> @@ -312,10 +312,12 @@ static irqreturn_t wl1271_irq(int irq, void *cookie)
> return IRQ_HANDLED;
> }
>
> -static void wl1271_spi_set_power(struct wl1271 *wl, bool enable)
> +static int wl1271_spi_set_power(struct wl1271 *wl, bool enable)
> {
> if (wl->set_power)
> wl->set_power(enable);
> +
> + return 0;
> }
>
> static struct wl1271_if_operations spi_ops = {
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-11 18:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 18:21 [PATCH v4 0/8] native support for wl1271 on ZOOM Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 1/8] wireless: wl1271: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 2/8] wireless: wl1271: support return value for the set power func Ohad Ben-Cohen
2010-08-11 18:35 ` DebBarma, Tarun Kanti [this message]
2010-08-11 22:19 ` Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data Ohad Ben-Cohen
2010-08-11 18:42 ` DebBarma, Tarun Kanti
2010-08-11 18:47 ` Felipe Balbi
2010-08-11 18:52 ` DebBarma, Tarun Kanti
2010-08-11 18:57 ` Felipe Balbi
2010-08-11 19:27 ` DebBarma, Tarun Kanti
2010-08-11 21:25 ` Russell King - ARM Linux
2010-08-11 22:15 ` Ohad Ben-Cohen
2010-08-12 6:40 ` Ohad Ben-Cohen
2010-08-12 9:55 ` Russell King - ARM Linux
2010-08-13 0:01 ` Ohad Ben-Cohen
2010-08-16 4:21 ` DebBarma, Tarun Kanti
2010-08-12 5:21 ` Felipe Balbi
2010-08-11 21:21 ` Russell King - ARM Linux
2010-08-11 20:10 ` Ohad Ben-Cohen
2010-08-11 21:34 ` Vitaly Wool
2010-08-11 22:18 ` Ohad Ben-Cohen
2010-08-12 5:27 ` Felipe Balbi
2010-08-11 18:21 ` [PATCH v4 4/8] wireless: wl1271: take irq info from private " Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 5/8] wireless: wl1271: make ref_clock configurable by board Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 6/8] omap: hsmmc: remove unused variable Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 7/8] omap: zoom: add fixed regulator device for wlan Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 8/8] omap: zoom: add mmc3/wl1271 device support Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A47E75E594F054BAF48C5E4FC4B92AB0324110ABB@dbde02.ent.ti.com \
--to=tarun.kanti@ti.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ido@wizery.com \
--cc=kalle.valo@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
--cc=madhu.cr@ti.com \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).