From: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
To: "felipe.balbi@nokia.com" <felipe.balbi@nokia.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Ido Yariv <ido@wizery.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>,
"Coelho Luciano (Nokia-MS/Helsinki)" <Luciano.Coelho@nokia.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
San Mehat <san@google.com>,
"Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@nokia.com>,
Tony Lindgren <tony@atomide.com>,
Nicolas Pitre <nico@fluxnic.net>,
"Pandita, Vikram" <vikram.pandita@ti.com>,
Kalle Valo <kalle.valo@iki.fi>
Subject: RE: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data
Date: Thu, 12 Aug 2010 00:22:54 +0530 [thread overview]
Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB0324110AC1@dbde02.ent.ti.com> (raw)
In-Reply-To: <20100811184742.GA21778@nokia.com>
> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
> Sent: Thursday, August 12, 2010 12:18 AM
> To: DebBarma, Tarun Kanti
> Cc: Ohad Ben-Cohen; linux-wireless@vger.kernel.org; linux-
> mmc@vger.kernel.org; linux-omap@vger.kernel.org; Ido Yariv; Mark Brown;
> linux-arm-kernel@lists.infradead.org; Chikkature Rajashekar, Madhusudhan;
> Coelho Luciano (Nokia-MS/Helsinki); akpm@linux-foundation.org; San Mehat;
> Quadros Roger (Nokia-MS/Helsinki); Tony Lindgren; Nicolas Pitre; Pandita,
> Vikram; Kalle Valo
> Subject: Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get
> board data
>
> hi,
>
> On Wed, Aug 11, 2010 at 08:42:18PM +0200, ext DebBarma, Tarun Kanti wrote:
> >> @@ -182,10 +186,84 @@ static struct wl1271_if_operations sdio_ops = {
> >> .disable_irq = wl1271_sdio_disable_interrupts
> >> };
> >>
> >> +static int wl1271_plat_probe(struct platform_device *pdev)
> >> +{
> >> + struct wl12xx_platform_data *pdata;
> >> + struct platform_driver *pdriver;
> >> + struct wl12xx_plat_instance *pinstance;
> >> +
> >What about checking for pdev here before extracting pdata?
>
> why ? if probe is called pdev is guaranteed to be valid, no ?
>
True; however if we go by that argument than we can also assume pdata is valid, so that we would not need the below check.
Still, I would go ahead and find out if there is any scenario where pdev can go wrong during device registration. Thanks.
> >> + pdata = pdev->dev.platform_data;
> >> + if (!pdata) {
> >> + wl1271_error("no platform data");
> >> + return -ENODEV;
> >> + }
> >> +
> >> + pdriver = container_of(pdev->dev.driver, struct platform_driver,
> >> + driver);
>
> but you shouldn't fiddle with the driver structure here. What are you
> actually trying to achieve here ? What's pinstance supposed to do ? are
> you trying to handle cases where you might have several wl12xx chips on
> the same board ? If that's the case you should have several platform
> devices, one for each chip. They'll only have different ids.
>
> --
> balbi
>
> DefectiveByDesign.org
next prev parent reply other threads:[~2010-08-11 18:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 18:21 [PATCH v4 0/8] native support for wl1271 on ZOOM Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 1/8] wireless: wl1271: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 2/8] wireless: wl1271: support return value for the set power func Ohad Ben-Cohen
2010-08-11 18:35 ` DebBarma, Tarun Kanti
2010-08-11 22:19 ` Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data Ohad Ben-Cohen
2010-08-11 18:42 ` DebBarma, Tarun Kanti
2010-08-11 18:47 ` Felipe Balbi
2010-08-11 18:52 ` DebBarma, Tarun Kanti [this message]
2010-08-11 18:57 ` Felipe Balbi
2010-08-11 19:27 ` DebBarma, Tarun Kanti
2010-08-11 21:25 ` Russell King - ARM Linux
2010-08-11 22:15 ` Ohad Ben-Cohen
2010-08-12 6:40 ` Ohad Ben-Cohen
2010-08-12 9:55 ` Russell King - ARM Linux
2010-08-13 0:01 ` Ohad Ben-Cohen
2010-08-16 4:21 ` DebBarma, Tarun Kanti
2010-08-12 5:21 ` Felipe Balbi
2010-08-11 21:21 ` Russell King - ARM Linux
2010-08-11 20:10 ` Ohad Ben-Cohen
2010-08-11 21:34 ` Vitaly Wool
2010-08-11 22:18 ` Ohad Ben-Cohen
2010-08-12 5:27 ` Felipe Balbi
2010-08-11 18:21 ` [PATCH v4 4/8] wireless: wl1271: take irq info from private " Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 5/8] wireless: wl1271: make ref_clock configurable by board Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 6/8] omap: hsmmc: remove unused variable Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 7/8] omap: zoom: add fixed regulator device for wlan Ohad Ben-Cohen
2010-08-11 18:21 ` [PATCH v4 8/8] omap: zoom: add mmc3/wl1271 device support Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A47E75E594F054BAF48C5E4FC4B92AB0324110AC1@dbde02.ent.ti.com \
--to=tarun.kanti@ti.com \
--cc=Luciano.Coelho@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=felipe.balbi@nokia.com \
--cc=ido@wizery.com \
--cc=kalle.valo@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).