* [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() [not found] ` <582529c23f77af64373f59fa92e29186df700d79.1448456395.git.geliangtang@163.com> @ 2015-11-25 13:12 ` Geliang Tang 2015-11-25 13:47 ` Grumbach, Emmanuel 0 siblings, 1 reply; 2+ messages in thread From: Geliang Tang @ 2015-11-25 13:12 UTC (permalink / raw) To: Johannes Berg, Emmanuel Grumbach, Intel Linux Wireless, Kalle Valo Cc: Geliang Tang, linux-wireless, netdev, linux-kernel WARN_ON_ONCE() takes a condition rather than a format string. This patch converted WARN_ON_ONCE() to WARN_ONCE() instead. Signed-off-by: Geliang Tang <geliangtang@163.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index d1ad103..58d7bee 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c @@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm *mvm, rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : LQ_HT_MIMO2; rate_mask = lq_sta->active_mimo2_rate; } else { - WARN_ON_ONCE("Bad column mode"); + WARN_ONCE(1, "Bad column mode"); } if (column->mode != RS_LEGACY) { -- 2.5.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() 2015-11-25 13:12 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Geliang Tang @ 2015-11-25 13:47 ` Grumbach, Emmanuel 0 siblings, 0 replies; 2+ messages in thread From: Grumbach, Emmanuel @ 2015-11-25 13:47 UTC (permalink / raw) To: Geliang Tang, Berg, Johannes, linuxwifi, Kalle Valo Cc: linux-wireless, netdev, linux-kernel > > WARN_ON_ONCE() takes a condition rather than a format string. This patch > converted WARN_ON_ONCE() to WARN_ONCE() instead. > > Signed-off-by: Geliang Tang <geliangtang@163.com> > --- > drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Already fixed. Thanks. > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > index d1ad103..58d7bee 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > @@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm > *mvm, > rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : > LQ_HT_MIMO2; > rate_mask = lq_sta->active_mimo2_rate; > } else { > - WARN_ON_ONCE("Bad column mode"); > + WARN_ONCE(1, "Bad column mode"); > } > > if (column->mode != RS_LEGACY) { > -- > 2.5.0 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-25 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com>
[not found] ` <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com>
[not found] ` <582529c23f77af64373f59fa92e29186df700d79.1448456395.git.geliangtang@163.com>
2015-11-25 13:12 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Geliang Tang
2015-11-25 13:47 ` Grumbach, Emmanuel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).