* [net-next] mwifiex: use eth_broadcast_addr() to assign broadcast address
@ 2019-07-10 7:25 Mao Wenan
2019-07-24 1:32 ` maowenan
0 siblings, 1 reply; 5+ messages in thread
From: Mao Wenan @ 2019-07-10 7:25 UTC (permalink / raw)
To: amitkarwar, nishants, gbhat, huxinming820, kvalo
Cc: linux-wireless, kernel-janitors, Mao Wenan
This patch is to use eth_broadcast_addr() to assign broadcast address
insetad of memcpy().
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/net/wireless/marvell/mwifiex/tdls.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c
index 18e654d..0931304 100644
--- a/drivers/net/wireless/marvell/mwifiex/tdls.c
+++ b/drivers/net/wireless/marvell/mwifiex/tdls.c
@@ -731,7 +731,6 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv,
u16 status_code, struct sk_buff *skb)
{
struct ieee80211_mgmt *mgmt;
- u8 bc_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
int ret;
u16 capab;
struct ieee80211_ht_cap *ht_cap;
@@ -765,7 +764,7 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv,
memmove(pos + ETH_ALEN, &mgmt->u.action.category,
sizeof(mgmt->u.action.u.tdls_discover_resp));
/* init address 4 */
- memcpy(pos, bc_addr, ETH_ALEN);
+ eth_broadcast_addr(pos);
ret = mwifiex_tdls_append_rates_ie(priv, skb);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [net-next] mwifiex: use eth_broadcast_addr() to assign broadcast address
2019-07-10 7:25 [net-next] mwifiex: use eth_broadcast_addr() to assign broadcast address Mao Wenan
@ 2019-07-24 1:32 ` maowenan
2019-07-24 5:42 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: maowenan @ 2019-07-24 1:32 UTC (permalink / raw)
To: amitkarwar, nishants, gbhat, huxinming820, kvalo
Cc: linux-wireless, kernel-janitors
gentle ping...
On 2019/7/10 15:25, Mao Wenan wrote:
> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memcpy().
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/net/wireless/marvell/mwifiex/tdls.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c
> index 18e654d..0931304 100644
> --- a/drivers/net/wireless/marvell/mwifiex/tdls.c
> +++ b/drivers/net/wireless/marvell/mwifiex/tdls.c
> @@ -731,7 +731,6 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv,
> u16 status_code, struct sk_buff *skb)
> {
> struct ieee80211_mgmt *mgmt;
> - u8 bc_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
> int ret;
> u16 capab;
> struct ieee80211_ht_cap *ht_cap;
> @@ -765,7 +764,7 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv,
> memmove(pos + ETH_ALEN, &mgmt->u.action.category,
> sizeof(mgmt->u.action.u.tdls_discover_resp));
> /* init address 4 */
> - memcpy(pos, bc_addr, ETH_ALEN);
> + eth_broadcast_addr(pos);
>
> ret = mwifiex_tdls_append_rates_ie(priv, skb);
> if (ret) {
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [net-next] mwifiex: use eth_broadcast_addr() to assign broadcast address
2019-07-24 1:32 ` maowenan
@ 2019-07-24 5:42 ` Kalle Valo
2019-07-24 6:25 ` [PATCH wireless-drivers-next v2] " Mao Wenan
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2019-07-24 5:42 UTC (permalink / raw)
To: maowenan
Cc: amitkarwar, nishants, gbhat, huxinming820, linux-wireless,
kernel-janitors
maowenan <maowenan@huawei.com> writes:
> gentle ping...
I don't apply patches during the merge window, so you just have to wait
untill I'll open wireless-drivers-next. And this for
wireless-drivers-next, not net-next.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH wireless-drivers-next v2] mwifiex: use eth_broadcast_addr() to assign broadcast address
2019-07-24 5:42 ` Kalle Valo
@ 2019-07-24 6:25 ` Mao Wenan
2019-07-24 11:56 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Mao Wenan @ 2019-07-24 6:25 UTC (permalink / raw)
To: kvalo, amitkarwar, nishants, gbhat, huxinming820
Cc: linux-wireless, kernel-janitors
This patch is to use eth_broadcast_addr() to assign broadcast address
insetad of memcpy().
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
v1->v2: change subject from net-next to wireless-drivers-next.
drivers/net/wireless/marvell/mwifiex/tdls.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c
index 18e654d..0931304 100644
--- a/drivers/net/wireless/marvell/mwifiex/tdls.c
+++ b/drivers/net/wireless/marvell/mwifiex/tdls.c
@@ -731,7 +731,6 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv,
u16 status_code, struct sk_buff *skb)
{
struct ieee80211_mgmt *mgmt;
- u8 bc_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
int ret;
u16 capab;
struct ieee80211_ht_cap *ht_cap;
@@ -765,7 +764,7 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv,
memmove(pos + ETH_ALEN, &mgmt->u.action.category,
sizeof(mgmt->u.action.u.tdls_discover_resp));
/* init address 4 */
- memcpy(pos, bc_addr, ETH_ALEN);
+ eth_broadcast_addr(pos);
ret = mwifiex_tdls_append_rates_ie(priv, skb);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-24 11:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 7:25 [net-next] mwifiex: use eth_broadcast_addr() to assign broadcast address Mao Wenan
2019-07-24 1:32 ` maowenan
2019-07-24 5:42 ` Kalle Valo
2019-07-24 6:25 ` [PATCH wireless-drivers-next v2] " Mao Wenan
2019-07-24 11:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).