From: Kalle Valo <kvalo@codeaurora.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Luca Coelho <luciano.coelho@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()
Date: Sat, 13 Mar 2021 07:31:16 +0200 [thread overview]
Message-ID: <87h7lfbowr.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <nycvar.YFH.7.76.2103130242460.12405@cbobk.fhfr.pm> (Jiri Kosina's message of "Sat, 13 Mar 2021 02:44:12 +0100 (CET)")
Jiri Kosina <jikos@kernel.org> writes:
> On Mon, 8 Mar 2021, Jiri Kosina wrote:
>
>> > From: Jiri Kosina <jkosina@suse.cz>
>> >
>> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs
>> > disabled (e.g. from LED core). We can't enable BHs in such a situation.
>> >
>> > Turn the unconditional BH-enable/BH-disable code into
>> > hardirq-disable/conditional-enable.
>> >
>> > This fixes the warning below.
>>
>> Hi,
>>
>> friendly ping on this one ...
>
> Luca,
>
> Johannes is telling me that he merged this patch internally, but I have no
> idea what is happening to it ... ?
>
> The reported splat is a clear bug, so it should be fixed one way or the
> other.
Should I take this to wireless-drivers?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-03-13 5:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 10:26 [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd() Jiri Kosina
2021-03-08 8:25 ` Jiri Kosina
2021-03-13 1:44 ` Jiri Kosina
2021-03-13 5:31 ` Kalle Valo [this message]
2021-03-13 5:49 ` Sedat Dilek
2021-03-13 15:43 ` Jiri Kosina
2021-03-13 16:32 ` Luca Coelho
2021-03-13 17:06 ` Kalle Valo
2021-03-13 17:35 ` Luca Coelho
2021-03-22 12:12 ` Jiri Kosina
2021-03-23 9:13 ` Sedat Dilek
2021-03-23 9:25 ` Jiri Kosina
2021-03-23 9:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7lfbowr.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=emmanuel.grumbach@intel.com \
--cc=jikos@kernel.org \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).