From: Jiri Kosina <jikos@kernel.org>
To: Luca Coelho <luca@coelho.fi>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()
Date: Mon, 22 Mar 2021 13:12:51 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2103221311560.12405@cbobk.fhfr.pm> (raw)
In-Reply-To: <c1681fa49280189c48ecf9f86fe54b81d662dc07.camel@coelho.fi>
On Sat, 13 Mar 2021, Luca Coelho wrote:
> > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs
> > > > > > > > disabled (e.g. from LED core). We can't enable BHs in such a situation.
> > > > > > > >
> > > > > > > > Turn the unconditional BH-enable/BH-disable code into
> > > > > > > > hardirq-disable/conditional-enable.
> > > > > > > >
> > > > > > > > This fixes the warning below.
> > > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > friendly ping on this one ...
> > > > > >
> > > > > > Luca,
> > > > > >
> > > > > > Johannes is telling me that he merged this patch internally, but I have no
> > > > > > idea what is happening to it ... ?
> > > > > >
> > > > > > The reported splat is a clear bug, so it should be fixed one way or the
> > > > > > other.
> > > > >
> > > > > Should I take this to wireless-drivers?
> > > >
> > > > I can't speak for the maintainers, but as far as I am concerned, it
> > > > definitely is a 5.12 material, as it fixes real scheduling bug.
> > >
> > > Yes, please take this to w-d. We have a similar patch internally, but
> > > there's a backlog and it will take me some time to get to it. I'll
> > > resolve eventual conflicts when time comes.
> >
> > Ok, can I have your ack for patchwork?
>
> Sorry, forgot that.
>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
Sorry for sounding like broken record :) but this fix is still not in any
tree as far as I can tell. And it's fixing real scheduling in atomic bug.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-03-22 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 10:26 [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd() Jiri Kosina
2021-03-08 8:25 ` Jiri Kosina
2021-03-13 1:44 ` Jiri Kosina
2021-03-13 5:31 ` Kalle Valo
2021-03-13 5:49 ` Sedat Dilek
2021-03-13 15:43 ` Jiri Kosina
2021-03-13 16:32 ` Luca Coelho
2021-03-13 17:06 ` Kalle Valo
2021-03-13 17:35 ` Luca Coelho
2021-03-22 12:12 ` Jiri Kosina [this message]
2021-03-23 9:13 ` Sedat Dilek
2021-03-23 9:25 ` Jiri Kosina
2021-03-23 9:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2103221311560.12405@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).