From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: don't apply flow control on management frames
Date: Mon, 22 Mar 2021 11:37:53 +0100 [thread overview]
Message-ID: <87wntz8oe6.fsf@toke.dk> (raw)
In-Reply-To: <e0ca70f2241307c44489653d7074c5017ad93943.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> On Sat, 2021-03-20 at 01:13 +0100, Toke Høiland-Jørgensen wrote:
>>
>> One consequence of this is that we create a strict priority queue for
>> management frames.
>
> Yes, for iwlwifi that's actually a change. For everyone else (not
> setting BUFF_MMPDU_TXQ or STA_MMPDU_TXQ) it already is since it goes
> directly to ->tx() and from there to the hardware queue(s).
Ah, right, of course; so not much change at all. Cool.
>> With all the possibilities for badness (such as the
>> ability of starving all other queues) that carries with it. I guess
>> that's probably fine for management frames, though, right? As in, there
>> is some other mechanism that prevents abuse of this?
>
> Well, there's just not that many management frames to start with? And
> only wpa_supplicant (or root in general) can create them. So I don't
> think we need to worry about that yet. With QoS-mgmt frames we might
> eventually want to think about that, but even there I'd say we never
> really want to drop them.
Yup, that's what I meant with "some other mechanism to prevent abuse".
Great.
Feel free to add my:
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2021-03-22 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 22:28 [PATCH] mac80211: don't apply flow control on management frames Johannes Berg
2021-03-20 0:13 ` Toke Høiland-Jørgensen
2021-03-20 19:58 ` Johannes Berg
2021-03-22 10:37 ` Toke Høiland-Jørgensen [this message]
2021-03-22 9:43 ` Maxime Bizon
2021-03-22 9:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wntz8oe6.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).