From: Johannes Berg <johannes@sipsolutions.net>
To: mbizon@freebox.fr, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: don't apply flow control on management frames
Date: Mon, 22 Mar 2021 10:46:28 +0100 [thread overview]
Message-ID: <e338e57075680c4a9e1323c7f4d6bfff1268d4e2.camel@sipsolutions.net> (raw)
In-Reply-To: <5f037c3f8485a8c929548be6a153290ba9ae4f13.camel@freebox.fr>
Hi,
On Mon, 2021-03-22 at 10:43 +0100, Maxime Bizon wrote:
> > Short-circuit the processing of management frames. To keep the
> > impact minimal, only put them on the frags queue and check the
> > tid == management only for doing that and to skip the airtime
> > fairness checks, if applicable.
>
> After your patch, what are the actual effects of HW_STA_MMPDU_TXQ and
> HW_BUFF_MMPDU_TXQ ?
Well, my patch doesn't change the effect of those significantly.
The idea for iwlwifi was that it doesn't actually like ->tx() to get
called, but much prefers a TXQ where the frame is, and then it can pull
it whenever it can transmit it.
This was the key requirement here, and it doesn't change: instead of
tx() getting called with the frames, the frames go to the TXQ instead
and wake_tx_queue() is called, and then the driver later pulls the
frames and pushes them to the hardware.
What does change is that management frames are no longer subject to
codel and inter-flow issues, and also note that the hash of a management
frame isn't actually well-defined.
johannes
prev parent reply other threads:[~2021-03-22 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 22:28 [PATCH] mac80211: don't apply flow control on management frames Johannes Berg
2021-03-20 0:13 ` Toke Høiland-Jørgensen
2021-03-20 19:58 ` Johannes Berg
2021-03-22 10:37 ` Toke Høiland-Jørgensen
2021-03-22 9:43 ` Maxime Bizon
2021-03-22 9:46 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e338e57075680c4a9e1323c7f4d6bfff1268d4e2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).